ide: fix pre-EIDE SWDMA support on big-endian

Previous thread: fs: rename buffer trylock by Linux Kernel Mailing List on Monday, August 4, 2008 - 10:00 pm. (1 message)

Next thread: Fix USB storage hang on command abort by Linux Kernel Mailing List on Tuesday, August 5, 2008 - 4:59 pm. (1 message)
From: Linux Kernel Mailing List
Date: Tuesday, August 5, 2008 - 4:59 pm

Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=367fdc...
Commit:     367fdcb4e401161e51aaee5d06b3f82098bafefc
Parent:     ca5de404ff036a29b25e9a83f6919c9f606c5841
Author:     Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
AuthorDate: Tue Aug 5 18:16:55 2008 +0200
Committer:  Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
CommitDate: Tue Aug 5 18:16:55 2008 +0200

    ide: fix pre-EIDE SWDMA support on big-endian
    
    id->tDMA is of 'unsigned char' type so endianness is already
    correct and calling le16_to_cpu() is wrong.
    
    Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-dma.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
index 71c377a..adc6827 100644
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -649,11 +649,7 @@ static unsigned int ide_get_mode_mask(ide_drive_t *drive, u8 base, u8 req_mode)
 		if (id->field_valid & 2) {
 			mask = id->dma_1word & hwif->swdma_mask;
 		} else if (id->tDMA) {
-			/*
-			 * ide_fix_driveid() doesn't convert ->tDMA to the
-			 * CPU endianness so we need to do it here
-			 */
-			u8 mode = le16_to_cpu(id->tDMA);
+			u8 mode = id->tDMA;
 
 			/*
 			 * if the mode is valid convert it to the mask
--

Previous thread: fs: rename buffer trylock by Linux Kernel Mailing List on Monday, August 4, 2008 - 10:00 pm. (1 message)

Next thread: Fix USB storage hang on command abort by Linux Kernel Mailing List on Tuesday, August 5, 2008 - 4:59 pm. (1 message)