USB: fix build on OMAPs if CONFIG_PM_RUNTIME is not set

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Friday, April 30, 2010 - 10:59 am

Gitweb:     http://git.kernel.org/linus/6d602610099632a9a15ef6d2bc9fd7b7d6aeb63e
Commit:     6d602610099632a9a15ef6d2bc9fd7b7d6aeb63e
Parent:     82a5eeb9f486366ad1b6c3be2e0d328ca185aa7e
Author:     Anand Gadiyar <gadiyar@ti.com>
AuthorDate: Mon Mar 29 16:54:51 2010 +0530
Committer:  Greg Kroah-Hartman <gregkh@suse.de>
CommitDate: Fri Apr 30 09:25:11 2010 -0700

    USB: fix build on OMAPs if CONFIG_PM_RUNTIME is not set
    
    With patch as1329 (USB: convert to the runtime PM framework),
    we make USB_SUSPEND depend on PM_RUNTIME instead of CONFIG_PM.
    
    Also, CONFIG_USB_OTG selects CONFIG_USB_SUSPEND.
    
    If PM_RUNTIME is not enabled, and we try to enable USB_OTG,
    we will end up with CONFIG_USB_SUSPEND selected. This is
    due to a known bug with the select statement.
    
    This makes the build break on various OMAP configs (which
    have CONFIG_USB_OTG set by default, but do not yet have
    CONFIG_PM_RUNTIME enabled).
    
    Avoid this by changing the logic for CONFIG_USB_OTG from
    "select USB_SUSPEND" to "depends on USB_SUSPEND"
    
    Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
    CC: Michal Marek <mmarek@suse.cz>
    CC: Tony Lindgren <tony@atomide.com>
    CC: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/usb/core/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index 97a819c..7e59444 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -109,7 +109,7 @@ config USB_SUSPEND
 config USB_OTG
 	bool
 	depends on USB && EXPERIMENTAL
-	select USB_SUSPEND
+	depends on USB_SUSPEND
 	default n
 
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
USB: fix build on OMAPs if CONFIG_PM_RUNTIME is not set, Linux Kernel Mailing ..., (Fri Apr 30, 10:59 am)