ext3 uses rb_node = NULL; to zero rb_root.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Sunday, May 30, 2010 - 9:59 am

Gitweb:     http://git.kernel.org/linus/1513b02c8b537af275ea74fdfb380c618b9e6778
Commit:     1513b02c8b537af275ea74fdfb380c618b9e6778
Parent:     4dea496974e41814cc715db0268226c6f71f7c8a
Author:     Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
AuthorDate: Tue May 25 16:03:04 2010 +0200
Committer:  Jan Kara <jack@suse.cz>
CommitDate: Thu May 27 17:39:36 2010 +0200

    ext3 uses rb_node = NULL; to zero rb_root.
    
    The problem with this is that 17d9ddc72fb8bba0d4f678 ("rbtree: Add support
    for augmented rbtrees") in the linux-next tree adds a new field to that
    struct which needs to be NULLas well.  This patch uses RB_ROOT as the
    intializer so all of the relevant fields will be NULL'd.
    
    Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
    Cc: Eric Paris <eparis@redhat.com>
    Cc: Jan Kara <jack@suse.cz>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/ext3/dir.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext3/dir.c b/fs/ext3/dir.c
index 373fa90..e2e72c3 100644
--- a/fs/ext3/dir.c
+++ b/fs/ext3/dir.c
@@ -297,7 +297,7 @@ static void free_rb_tree_fname(struct rb_root *root)
 			kfree (old);
 		}
 		if (!parent)
-			root->rb_node = NULL;
+			*root = RB_ROOT;
 		else if (parent->rb_left == n)
 			parent->rb_left = NULL;
 		else if (parent->rb_right == n)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ext3 uses rb_node = NULL; to zero rb_root., Linux Kernel Mailing ..., (Sun May 30, 9:59 am)