[PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS dependency

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Petr Baudis
Date: Saturday, June 24, 2006 - 6:40 pm

Signed-off-by: Petr Baudis <pasky@suse.cz>
---

  This one should do a better job; if we quote, let's do it proper. :-)

 Makefile |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 9a59466..fb9ffad 100644
--- a/Makefile
+++ b/Makefile
@@ -608,11 +608,15 @@ XDIFF_OBJS=xdiff/xdiffi.o xdiff/xprepare
 	rm -f $@ && $(AR) rcs $@ $(XDIFF_OBJS)
 
 
-perl/Makefile:	perl/Git.pm perl/Makefile.PL
+PERL_DEFINE = $(ALL_CFLAGS) -DGIT_VERSION='"$(GIT_VERSION)"'
+PERL_DEFINE_SQ = $(subst ','\'',$(PERL_DEFINE))
+PERL_LIBS = $(EXTLIBS)
+PERL_LIBS_SQ = $(subst ','\'',$(PERL_LIBS))
+perl/Makefile:	perl/Git.pm perl/Makefile.PL GIT-CFLAGS
 	(cd perl && $(PERL_PATH) Makefile.PL \
-		PREFIX="$(prefix)" \
-		DEFINE="$(ALL_CFLAGS) -DGIT_VERSION=\\\"$(GIT_VERSION)\\\"" \
-		LIBS="$(EXTLIBS)")
+		PREFIX='$(prefix_SQ)' \
+		DEFINE='$(PERL_DEFINE_SQ)' \
+		LIBS='$(PERL_LIBS)')
 
 doc:
 	$(MAKE) -C Documentation all

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
PPC SHA-1 Updates in &quot;pu&quot;, Junio C Hamano, (Sat Jun 24, 3:03 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Linus Torvalds, (Sat Jun 24, 11:55 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Junio C Hamano, (Sat Jun 24, 1:21 pm)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Linus Torvalds, (Sat Jun 24, 1:42 pm)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Junio C Hamano, (Sat Jun 24, 4:59 pm)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Petr Baudis, (Sat Jun 24, 6:02 pm)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Petr Baudis, (Sat Jun 24, 6:24 pm)
[PATCH] Git.pm build: Fix quoting and missing GIT-CFLAGS d ..., Petr Baudis, (Sat Jun 24, 6:40 pm)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Junio C Hamano, (Sat Jun 24, 8:57 pm)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Petr Baudis, (Sun Jun 25, 2:34 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Johannes Schindelin, (Sun Jun 25, 3:07 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Petr Baudis, (Sun Jun 25, 3:20 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Junio C Hamano, (Sun Jun 25, 3:48 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Johannes Schindelin, (Sun Jun 25, 6:44 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Randal L. Schwartz, (Sun Jun 25, 11:46 am)
Re: PPC SHA-1 Updates in &quot;pu&quot;, Johannes Schindelin, (Sun Jun 25, 4:23 pm)
GIt.xs merge status, Junio C Hamano, (Thu Jun 29, 6:28 pm)
Re: GIt.xs merge status, Pavel Roskin, (Thu Jun 29, 10:08 pm)
Re: Git.xs merge status, Junio C Hamano, (Fri Jun 30, 12:18 am)
Re: Git.xs merge status, Pavel Roskin, (Fri Jun 30, 12:28 am)
Re: GIt.xs merge status, Johannes Schindelin, (Fri Jun 30, 2:53 am)
Re: GIt.xs merge status, Junio C Hamano, (Fri Jun 30, 3:26 am)