Re: Cloning empty repositories, was Re: What is the idea for bare repositories?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeff King
Date: Saturday, November 17, 2007 - 5:25 pm

Junio, can I get an ACK or NAK on the patch below? There doesn't seem to
be a patch for making cloning empty repos work on the horizon, but can
we at least improve the error message?

-- >8 --
git-clone: print an error message when trying to clone empty repo

Previously, cloning an empty repository looked like this:

$ (mkdir parent && cd parent && git --bare init)
$ git-clone parent child
Initialized empty Git repository in /home/peff/clone/child/.git/
$ cd child
-bash: cd: child: No such file or directory
$ echo 'wtf?' | mail git@vger.kernel.org

Now we at least report that the clone was not successful.

---
diff --git a/git-clone.sh b/git-clone.sh
index 18003ab..e2b7a9c 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -278,7 +278,8 @@ yes)
 				      find objects -type f -print | sed -e 1q)
 			# objects directory should not be empty because
 			# we are cloning!
-			test -f "$repo/$sample_file" || exit
+			test -f "$repo/$sample_file" ||
+				die "fatal: cannot clone empty repository"
 			if ln "$repo/$sample_file" "$GIT_DIR/objects/sample" 2>/dev/null
 			then
 				rm -f "$GIT_DIR/objects/sample"

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
What is the idea for bare repositories?, David Kastrup, (Mon Nov 12, 6:11 am)
Re: What is the idea for bare repositories?, Bruno Cesar Ribas, (Mon Nov 12, 6:19 am)
Re: What is the idea for bare repositories?, Johannes Schindelin, (Mon Nov 12, 6:57 am)
Re: What is the idea for bare repositories?, David Tweed, (Mon Nov 12, 7:20 am)
Re: What is the idea for bare repositories?, Jan Wielemaker, (Mon Nov 12, 9:19 am)
Cloning empty repositories, was Re: What is the idea for b ..., Johannes Schindelin, (Mon Nov 12, 9:34 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Mon Nov 12, 10:15 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Mon Nov 12, 10:30 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Mon Nov 12, 10:54 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Mon Nov 12, 10:57 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Mon Nov 12, 11:06 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Andreas Ericsson, (Mon Nov 12, 12:17 pm)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Mon Nov 12, 3:17 pm)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Tue Nov 13, 4:19 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Tue Nov 13, 4:56 pm)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Wed Nov 14, 1:58 pm)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Wed Nov 14, 5:28 pm)
Re: Cloning empty repositories, was Re: What is the idea f ..., Johannes Schindelin, (Thu Nov 15, 5:44 am)
Re: Cloning empty repositories, was Re: What is the idea f ..., Jeff King, (Sat Nov 17, 5:25 pm)