Hi,

On Mon, 5 Mar 2007, Paolo Bonzini wrote:

quoted text
> > Well, you make a good case there. I am only mildly concerned that this 
> > might not work on some obscure platforms (including Windows and 
> > SunOS), and that we are not even realizing that because you do not 
> > check the return value of sscanf().
> 
> I check that the %n's are written to, instead.

Yes, you also check real_ref instead of checking if dwim_ref() returned 0. 
I feel a little bit uneasy about that, since there is no guarantee that 
these values are left untouched, whereas the return value is guaranteed to 
behave as expected.

I also feel a little uneasy about having to parse a format in order to 
parse a string, when you know what that string should look like. For 
example, you could make the code even more compact by asking 
"(p = strstr(value, "/*:refs/remotes/"))".

But if other people do not feel as uneasy about these issues as I do, I 
certainly will not reject your patch.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html