Home » Mailing list archives » git » 2007 » June » 9

Re: [PATCH 06/21] Refactor tag name verification loop to use index 'i' instead of incrementing pointer 'tag_line'

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alex Riesen
Subject: Re: [PATCH 06/21] Refactor tag name verification loop to use index 'i' instead of incrementing pointer 'tag_line'
Date: Saturday, June 9, 2007 - 2:26 pm

On 6/9/07, Johan Herland <johan@herland.net> wrote:

What is this change good for?
How did you justify the type selection for your
loop index variable?

IOW,  the patch looks very useless.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH] Fix failed tag parsing when tag object has no ..., Junio C Hamano, (Fri Jun 8, 9:06 am)
[PATCH 0/21] Refactor the tag object (take 2), Johan Herland, (Fri Jun 8, 5:10 pm)
[PATCH 01/21] Remove unnecessary code and comments on non- ..., Johan Herland, (Fri Jun 8, 5:12 pm)
[PATCH 02/21] Return error messages when parsing fails., Johan Herland, (Fri Jun 8, 5:13 pm)
[PATCH 03/21] Refactoring to make verify_tag() and parse_t ..., Johan Herland, (Fri Jun 8, 5:13 pm)
[PATCH 04/21] Refactor verification of &quot;tagger&quot; line to be ..., Johan Herland, (Fri Jun 8, 5:14 pm)
[PATCH 05/21] Make parse_tag_buffer_internal() handle item ..., Johan Herland, (Fri Jun 8, 5:14 pm)
[PATCH 06/21] Refactor tag name verification loop to use i ..., Johan Herland, (Fri Jun 8, 5:15 pm)
[PATCH 07/21] Copy the remaining differences from verify_t ..., Johan Herland, (Fri Jun 8, 5:15 pm)
[PATCH 08/21] Switch from verify_tag() to parse_and_verify ..., Johan Herland, (Fri Jun 8, 5:15 pm)
[PATCH 09/21] Remove unneeded code from mktag.c, Johan Herland, (Fri Jun 8, 5:16 pm)
[PATCH 10/21] Free mktag's buffer before dying, Johan Herland, (Fri Jun 8, 5:16 pm)
[PATCH 11/21] Rewrite error messages; fix up line lengths, Johan Herland, (Fri Jun 8, 5:17 pm)
[PATCH 12/21] Use prefixcmp() instead of memcmp() for clea ..., Johan Herland, (Fri Jun 8, 5:17 pm)
[PATCH 13/21] Collect skipping of header field names and c ..., Johan Herland, (Fri Jun 8, 5:18 pm)
[PATCH 14/21] Add proper parsing of &quot;tagger&quot; line, but onl ..., Johan Herland, (Fri Jun 8, 5:18 pm)
[PATCH 15/21] Make tag names (i.e. the tag object's &quot;tag&quot; ..., Johan Herland, (Fri Jun 8, 5:19 pm)
[PATCH 16/21] Introduce optional &quot;keywords&quot; on tag objects, Johan Herland, (Fri Jun 8, 5:19 pm)
[PATCH 17/21] Update comments on tag objects in mktag.c, Johan Herland, (Fri Jun 8, 5:20 pm)
[PATCH 18/21] git-fsck: Do thorough verification of tag ob ..., Johan Herland, (Fri Jun 8, 5:20 pm)
[PATCH 19/21] Documentation/git-mktag: Document the change ..., Johan Herland, (Fri Jun 8, 5:20 pm)
[PATCH 20/21] git-mktag tests: Expand on mktag selftests a ..., Johan Herland, (Fri Jun 8, 5:21 pm)
[PATCH 21/21] Add fsck_verify_ref_to_tag_object() to verif ..., Johan Herland, (Fri Jun 8, 5:21 pm)
Re: [PATCH 03/21] Refactoring to make verify_tag() and par ..., Johannes Schindelin, (Fri Jun 8, 7:54 pm)
Re: [PATCH 03/21] Refactoring to make verify_tag() and par ..., Johan Herland, (Sat Jun 9, 3:49 am)
Re: [PATCH 06/21] Refactor tag name verification loop to u ..., Alex Riesen, (Sat Jun 9, 2:26 pm)
Re: [PATCH 07/21] Copy the remaining differences from veri ..., Alex Riesen, (Sat Jun 9, 2:31 pm)
Re: [PATCH 06/21] Refactor tag name verification loop to u ..., Johan Herland, (Sat Jun 9, 2:34 pm)
Re: [PATCH 10/21] Free mktag's buffer before dying, Alex Riesen, (Sat Jun 9, 2:37 pm)
Re: [PATCH 09/21] Remove unneeded code from mktag.c, Alex Riesen, (Sat Jun 9, 2:39 pm)
Re: [PATCH 07/21] Copy the remaining differences from veri ..., Johan Herland, (Sat Jun 9, 2:39 pm)
Re: [PATCH 12/21] Use prefixcmp() instead of memcmp() for ..., Alex Riesen, (Sat Jun 9, 2:42 pm)
Re: [PATCH 09/21] Remove unneeded code from mktag.c, Johan Herland, (Sat Jun 9, 2:42 pm)
Re: [PATCH 10/21] Free mktag's buffer before dying, Johan Herland, (Sat Jun 9, 2:46 pm)
Re: [PATCH 12/21] Use prefixcmp() instead of memcmp() for ..., Johan Herland, (Sat Jun 9, 2:47 pm)
Re: [PATCH 16/21] Introduce optional &quot;keywords&quot; on tag objects, Alex Riesen, (Sat Jun 9, 2:52 pm)
Re: [PATCH 10/21] Free mktag's buffer before dying, Alex Riesen, (Sat Jun 9, 3:00 pm)
Re: [PATCH 16/21] Introduce optional &quot;keywords&quot; on tag objects, Johan Herland, (Sat Jun 9, 3:00 pm)
Re: [PATCH 10/21] Free mktag's buffer before dying, Johan Herland, (Sat Jun 9, 3:05 pm)
[PATCH] Use xstrndup() instead of xmalloc() and memcpy(); ..., Johan Herland, (Sat Jun 9, 3:36 pm)
Re: [PATCH 16/21] Introduce optional &quot;keywords&quot; on tag objects, Junio C Hamano, (Sat Jun 9, 5:05 pm)
[PATCH] Fail if tag name and keywords is not within &quot;print ..., Johan Herland, (Sat Jun 9, 5:35 pm)
Re: [PATCH] Fail if tag name and keywords is not within &quot;p ..., Junio C Hamano, (Sat Jun 9, 6:33 pm)
Re: [PATCH 05/21] Make parse_tag_buffer_internal() handle ..., Johannes Schindelin, (Sun Jun 10, 1:06 am)
Re: [PATCH 06/21] Refactor tag name verification loop to u ..., Johannes Schindelin, (Sun Jun 10, 1:14 am)
Re: [PATCH 07/21] Copy the remaining differences from veri ..., Johannes Schindelin, (Sun Jun 10, 1:22 am)
Re: [PATCH 10/21] Free mktag's buffer before dying, Johannes Schindelin, (Sun Jun 10, 1:38 am)
Re: [PATCH 11/21] Rewrite error messages; fix up line lengths, Johannes Schindelin, (Sun Jun 10, 1:38 am)
Re: [PATCH 12/21] Use prefixcmp() instead of memcmp() for ..., Johannes Schindelin, (Sun Jun 10, 1:41 am)
Re: [PATCH 13/21] Collect skipping of header field names a ..., Johannes Schindelin, (Sun Jun 10, 1:45 am)
Re: [PATCH 14/21] Add proper parsing of &quot;tagger&quot; line, but ..., Johannes Schindelin, (Sun Jun 10, 1:52 am)
Re: [PATCH 14/21] Add proper parsing of &quot;tagger&quot; line, but ..., Johannes Schindelin, (Sun Jun 10, 1:58 am)
Re: [PATCH 06/21] Refactor tag name verification loop to u ..., Johannes Schindelin, (Sun Jun 10, 2:01 am)
Re: [PATCH 15/21] Make tag names (i.e. the tag object's &quot;t ..., Johannes Schindelin, (Sun Jun 10, 2:07 am)