One note about using Sparse with Git: you almost certainly don't want to =
pass
-Wall to sparse, and current Git passes CFLAGS to Sparse which will do ex=
actly
that. -Wall turns on all possible Sparse warnings, including nitpicky
warnings and warnings with a high false positive rate. You should start =
from
the default set of Sparse warnings, and add additional warnings as desire=
d, or
turn off those you absolutely can't live with. Current Sparse from Git (=
post
0.3, after commit e18c1014449adf42520daa9d3e53f78a3d98da34) has a change =
to
cgcc to filter out -Wall, so you can pass -Wall to GCC but not Sparse. S=
ee
below for other reasons why you should use cgcc.
That said, this suggests that perhaps Sparse should treat -Wall different=
ly
for compatibility with GCC; specifically, perhaps Sparse should just igno=
re
-Wall, as its meaning with GCC (enable a reasonable default set of warnin=
gs)
already occurs by default in Sparse. The current -Wall could become some=
thing
like -Weverything. This would make Sparse somewhat less intuitive, but
" warning
er.]
And at one point prototypes didn't exist either. :)
Other valid null pointers exist, such as (void *)0. You could also use (=
char
*)0 in this particular case. Sparse complains because you just use the
integer 0. I suggest just using NULL.
If you want to keep using Z_NULL rather than NULL, you could always undef=
it
and define it as NULL after including the zlib header files.
If you really want to turn that particular Sparse warning off, you can us=
e
Note that you could do that much more simply by using:
gcc -E -dM -x c /dev/null | sed ...
Please go with that option. In addition to providing an easy way to use
sparse and GCC together (make CC=3Dcgcc), cgcc defines arch-specific flag=
s that
sparse currently does not. Ideally sparse should define these flags, but=
that
would add some architecture-specific logic to sparse, which would then re=
quire
sparse to know the ...
