[PATCHv2 0/2] fixes to gitweb feature check code

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Giuseppe Bilotta
Date: Friday, November 28, 2008 - 1:39 pm

This is v2 of the gitweb feature check fix patch, which has now been
split into into a code patch and cleanup patch.

The first patch introduces git_get_feature() to clearly distinguish the
feature retrieval from the boolean feature check (which is kept at
git_check_feature()). The new function is used where appropriate.

The second patch cleans up use of git_check_feature(): since the
function now returns a boolean instead of an array, the often-used
construct
  my ($somevar) = git_check_feature('somefeat');
although still valid, becomes a rather clumsy stylistic choice, as it
introduces an unnecessary ambiguity. Make it clear that we're now
dealing with scalars by using scalar assignment.

Giuseppe Bilotta (2):
  gitweb: fixes to gitweb feature check code
  gitweb: clean up git_check_feature() calls

 gitweb/gitweb.perl |   52 +++++++++++++++++++++++++++++++++++-----------------
 1 files changed, 35 insertions(+), 17 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv2 0/2] fixes to gitweb feature check code, Giuseppe Bilotta, (Fri Nov 28, 1:39 pm)
[PATCHv2 1/2] gitweb: fixes to gitweb feature check code, Giuseppe Bilotta, (Fri Nov 28, 1:39 pm)
[PATCHv2 2/2] gitweb: clean up git_check_feature() calls, Giuseppe Bilotta, (Fri Nov 28, 1:39 pm)
Re: [PATCHv2 0/2] fixes to gitweb feature check code, Jakub Narebski, (Sat Nov 29, 3:48 am)
Re: [PATCHv2 0/2] fixes to gitweb feature check code, Giuseppe Bilotta, (Sat Nov 29, 4:13 am)
[PATCHv2 2/2] gitweb: clean up gitweb_check_feature() calls, Giuseppe Bilotta, (Sat Nov 29, 4:15 am)
[PATCH] gitweb: fixes to gitweb feature check code, Giuseppe Bilotta, (Sat Nov 29, 6:34 pm)
Re: [PATCH] gitweb: fixes to gitweb feature check code, Jakub Narebski, (Mon Dec 1, 6:53 pm)
[PATCHv3bis] gitweb: fixes to gitweb feature check code, Giuseppe Bilotta, (Tue Dec 2, 3:43 am)
Re: [PATCH] gitweb: fixes to gitweb feature check code, Junio C Hamano, (Tue Dec 2, 2:55 pm)
Re: [PATCH] gitweb: fixes to gitweb feature check code, Jakub Narebski, (Tue Dec 2, 6:21 pm)