Home » Mailing list archives » git » 2008 » March » 13

Re: [PATCH 06/16] add test_cmp function for test scripts

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jeff King
Subject: Re: [PATCH 06/16] add test_cmp function for test scripts
Date: Thursday, March 13, 2008 - 5:08 am

On Wed, Mar 12, 2008 at 03:12:45PM -0700, Junio C Hamano wrote:


Oops, so you do. I remember discussing it but didn't recall a patch
coming out of it.

I see you have queued mine now in pu over yours. I actually think yours
looks a little nicer (you sanity-check the comparator, and you are more
careful with stdin (something that I considered, but figured we could
add if something actually broke)).

Any reason not to keep your existing one over mine?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 06/16] add test_cmp function for test scripts, Jeff King, (Wed Mar 12, 2:36 pm)
Re: [PATCH 06/16] add test_cmp function for test scripts, Junio C Hamano, (Wed Mar 12, 3:12 pm)
Re: [PATCH 06/16] add test_cmp function for test scripts, Jeff King, (Thu Mar 13, 5:08 am)
Re: [PATCH 06/16] add test_cmp function for test scripts, Junio C Hamano, (Thu Mar 13, 1:48 pm)