Re: git rebase interactive: usability issue

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Avery Pennarun
Date: Wednesday, June 25, 2008 - 8:59 pm

On 6/25/08, Junio C Hamano <gitster@pobox.com> wrote:

Perhaps the problem is more that people are encouraged to --amend so
often that they end up doing it by accident.

What if 'edit' worked more like 'squash', in that it produced the new
tree, but didn't commit it yet?  Then you can reset things, commit
them, or rebase --continue (which commits automatically if needed)
just like wish 'squash'.

I think --continue used to not commit automatically, so I can see why
edit used to commit for you, but maybe that behaviour is not needed
anymore.

Right now the asymmetry of having to use --amend with 'edit' but not
with 'squash' is what leads me to make mistakes sometimes.

Have fun,

Avery
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
git rebase interactive: usability issue, Dmitry Potapov, (Wed Jun 25, 4:32 pm)
Re: git rebase interactive: usability issue, Johannes Schindelin, (Wed Jun 25, 7:17 pm)
Re: git rebase interactive: usability issue, Junio C Hamano, (Wed Jun 25, 8:32 pm)
Re: git rebase interactive: usability issue, Avery Pennarun, (Wed Jun 25, 8:59 pm)
Re: git rebase interactive: usability issue, Dmitry Potapov, (Thu Jun 26, 4:35 am)
Re: git rebase interactive: usability issue, Theodore Tso, (Thu Jun 26, 5:13 am)