Re: [RFC PATCH] git-add--interactive: manual hunk editing mode v2

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Thomas Rast
Date: Sunday, June 8, 2008 - 3:33 pm

Jeff King wrote:

I think there's no way to split hunks, in the way I currently "help"
with @@ line guessing, using just the --recount feature.  Unless the
editor helps you with adding complete correct @@ lines in the middle
of hunks (Emacs does that).  I don't think it is at all possible to
remove the middle part of a hunk in Johannes' scheme without somehow
figuring out the corresponding @@ line (or at least its old line
number) or editing away every +/- line.

Then again it's not always easy even with my patch: you may have to
manually insert extra context because of the rule against zero lines
of context.  We could guess the context too if we already guessed the
line numbers, but that would mean even more complexity, which you
don't seem to like...

=2D Thomas

=2D-=20
Thomas Rast
trast@student.ethz.ch
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] git-add--interactive: manual hunk editing mode, Thomas Rast, (Fri May 23, 1:21 pm)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Thu May 29, 9:12 am)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Fri May 30, 2:49 am)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Jakub Narebski, (Fri May 30, 3:46 am)
Re: [PATCH] git-add--interactive: manual hunk editing mode, Junio C Hamano, (Fri May 30, 2:35 pm)
Re: [RFC PATCH] git-add--interactive: manual hunk editing ..., Johannes Schindelin, (Thu Jun 5, 3:28 am)
Re: [RFC PATCH] git-add--interactive: manual hunk editing ..., Johannes Schindelin, (Fri Jun 6, 7:31 am)
Re: [RFC PATCH] git-add--interactive: manual hunk editing ..., Thomas Rast, (Sun Jun 8, 3:33 pm)
Re: [RFC PATCH] git-add--interactive: manual hunk editing ..., Johannes Schindelin, (Sun Jun 8, 4:02 pm)
Re: [RFC PATCH] git-add--interactive: manual hunk editing ..., Johannes Schindelin, (Sun Jun 8, 4:06 pm)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Sun Jun 8, 4:19 pm)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Mon Jun 9, 9:13 am)
Re: [PATCH v3] git-add--interactive: manual hunk editing mode, Andreas Ericsson, (Tue Jun 10, 4:19 am)
Re: [PATCH v4] git-add--interactive: manual hunk editing mode, Johannes Schindelin, (Mon Jun 23, 11:54 am)
apply --recount, was Re: [PATCH v4] git-add--interactive: ..., Johannes Schindelin, (Mon Jun 23, 2:16 pm)
[PATCH 0/3] Manual editing for 'add' and 'add -p', Thomas Rast, (Tue Jun 24, 12:07 pm)
Re: [PATCH 0/3] Manual editing for 'add' and 'add -p', Miklos Vajna, (Tue Jun 24, 12:53 pm)
Re: [PATCH 1/3] Allow git-apply to ignore the hunk headers ..., Johannes Schindelin, (Fri Jun 27, 10:43 am)