extracting to/cc addresses for stg mail

Previous thread: More on git over HTTP POST by H. Peter Anvin on Friday, August 1, 2008 - 2:50 pm. (40 messages)

Next thread: [PATCH] bash completion: Add completion for 'git grep' by Lee Marlow on Friday, August 1, 2008 - 5:56 pm. (7 messages)
From: Bjorn Helgaas
Date: Friday, August 1, 2008 - 3:50 pm

I'm new to stg, so maybe I'm missing the easy way to do this.
That said, I'd like to maintain "To:" fields in the patch
description, like this:

  Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
  To: Andi Kleen <andi@firstfloor.org>
  Cc: Andrew Morton <akpm@linux-foundation.org>

"stg mail --auto" takes care of adding Andrew to the Cc list,
but I have to manually deal with Andi.

I've been doing that by using "stg mail --auto -E" and manually
moving the To: line to the top, but that's a hassle.  I don't
really want to use "stg mail --to=", because then I have to dig
out the To: line contents first.  I don't really want to use
different template files, because I often have one-off self-
contained patches that go different places.

Is there a way to make stg pay attention to my "To:" lines in
the patch description?  Or another way to accomplish this?

Bjorn
--

From: Karl
Date: Tuesday, August 5, 2008 - 6:39 am

It can't do it at the moment, but it should be easy to fix. In
stgit/commands/mail.py, the following lines

    if options.auto:
        extra_cc = __get_signers_list(descr)
    else:
        extra_cc = []

add the extra CC addresses. You could augment __get_signers_list to
return a tuple of to and cc addresses instead of just cc addresses,
pass those addesses to the same place extra_cc is fed now, and that's
it.

If you really hate Python, don't have time, etc., I can do it for you
(as long as you agree to test it) -- just ask -- but I try to take
every opportunity to get people to contribute patches. :-)

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
--

From: Bjorn Helgaas
Date: Tuesday, August 5, 2008 - 10:43 am

Thanks for the hints.  I'll take a look at it.  It'll take me a while,
but it's a good excuse to try to learn a little Python.

Bjorn
--

Previous thread: More on git over HTTP POST by H. Peter Anvin on Friday, August 1, 2008 - 2:50 pm. (40 messages)

Next thread: [PATCH] bash completion: Add completion for 'git grep' by Lee Marlow on Friday, August 1, 2008 - 5:56 pm. (7 messages)