Re: [PATCH v2] Support "core.excludesfile = ~/.gitignore"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeff King
Date: Tuesday, August 26, 2008 - 5:25 pm

On Mon, Aug 25, 2008 at 12:07:15PM -0700, Karl Chen wrote:


I think that is fine for now. One other simple possibility would be to
expand _just_ $HOME, and then if we later decided to do all environment
variables it would naturally encompass that. However, we might want to
support "~" then anyway, so I think doing "~" first is fine.

However, there are two problems with the patch:

  1. It should probably re-use path.c:user_path, as Johannes mentioned.

  2. There is no documentation update.

Also, are there any other config variables which would benefit from this
substitution (I can't think of any off-hand, but there are quite a few I
don't use).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Dropping core.worktree and GIT_WORK_TREE support, Junio C Hamano, (Sun Aug 24, 8:05 pm)
Re: Dropping core.worktree and GIT_WORK_TREE support, Miklos Vajna, (Mon Aug 25, 5:52 am)
Re: Dropping core.worktree and GIT_WORK_TREE support, Nguyen Thai Ngoc Duy, (Mon Aug 25, 6:52 am)
Re: [PATCH] git diff/diff-index/diff-files: call setup_wor ..., Nguyen Thai Ngoc Duy, (Mon Aug 25, 7:46 am)
Re: [PATCH] git diff/diff-index/diff-files: call setup_wor ..., Nguyen Thai Ngoc Duy, (Mon Aug 25, 8:26 am)
Re: Dropping core.worktree and GIT_WORK_TREE support, Junio C Hamano, (Mon Aug 25, 2:21 pm)
Re: Dropping core.worktree and GIT_WORK_TREE support, Miklos Vajna, (Mon Aug 25, 2:37 pm)
Re: Dropping core.worktree and GIT_WORK_TREE support (was ..., Michael J Gruber, (Tue Aug 26, 12:35 am)
Re: [PATCH v2] Support "core.excludesfile = ~/.gitignore", Jeff King, (Tue Aug 26, 5:25 pm)
[PATCH] diff*: fix worktree setup, Nguyễn Thái Ngọc Duy, (Thu Aug 28, 6:02 am)