Re: [PATCH 2/2] Improve portability: Avoid SS constant as it is already defined

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Wednesday, August 27, 2008 - 11:56 am

David Soria Parra <sn_@gmx.net> writes:


I do not mind this _particular_ workaround per-se, but I have to wonder
what happens the next time some random other platform has "SP" defined in
a random header file.

First of all, why are you including <sys/regset.h>?  We certainly don't
include from any of our header or source files.  And second of all, why is
the indirect inclusion of that header file by some standard header file we
do include cause the namespace to get poluted with "SS" symbol?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/2] Improve portability for OpenSolaris, David Soria Parra, (Wed Aug 27, 10:39 am)
[PATCH 1/2] Improvate portability: Display pid_t's always ..., David Soria Parra, (Wed Aug 27, 10:39 am)
[PATCH 2/2] Improve portability: Avoid SS constant as it i ..., David Soria Parra, (Wed Aug 27, 10:39 am)
Re: [PATCH 2/2] Improve portability: Avoid SS constant as ..., Junio C Hamano, (Wed Aug 27, 11:56 am)
Re: [PATCH 2/2] Improve portability: Avoid SS constant as ..., David Soria Parra, (Wed Aug 27, 5:34 pm)
Re: [PATCH 1/2] Improvate portability: Display pid_t's alw ..., David Soria Parra, (Sat Aug 30, 1:40 pm)