Re: [RFC] origin link for cherry-pick and revert

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Stephen R. van den Berg
Date: Thursday, September 11, 2008 - 5:31 am

Jakub Narebski wrote:


Rightfully so, of course.


Well, the train of thought here goes as follows:
1. Sure, why not add a field (zero or more) at the bottom of the free-form
   commit message reading like:

   Origin: bbb896d8e10f736bfda8f587c0009c358c9a8599 ee837244df2e2e4e9171f508f83f353730db9e53

2. Add support to cherry-pick/revert to actually generate the field upon
   demand.

3. Then add support to prune/gc/fsck/blame/log --graph to take the field
   into account.

4. Add support to filter-branch/rebase to renumber the field if necessary.

5. Add support to --topo-order to use the field if present and reachable.

6. For bonus points: add support to log to suppress the display of the
   field at the end of the commit message, and redisplay the field
   as Origin: bbb896d..ee83724
   next to the Parent/Merge fields.

Well, and after having done steps 1 to 5, the net result is that it
works almost as if the field is present in the header, except that:
- It is now at the end of the body in the commit message.
- It takes more time to find and parse it.

So that gives two minuses, and no pluses.
So short-circuiting the reasoning suggests that since the only thing
that actually changes now is the position of the field (at the top or
end of the commit message), we might as well do it right and put it in
the top, that gets rid of the two minuses.

Anything I missed?

Basically it means that:

a. If there is a better solution to tracking the backports, I'll gladly
   use that instead, but simply using the current really freeform
   approach doesn't cut it (it currently refers to a single commit,
   instead of a pair of commits, and takes too long to parse out in a
   --top-order or blame command).  Better solutions I haven't heard so
   far.

b. I need the integrity protection of a commit to make sure that the
   origin fields cannot be altered later; blame would be too easy to fool
   otherwise.  So using the notes solution seems to be out (it would also
   be quite a performance hit again).

c. I consider the Origin: field at the end of the commit message a
   workable solution, but it smells like X-header-extension-messes as in
   E-mail headers, and it incurs a small performance hit (in case of
   --topo-order/blame/prune/fsck), but maybe this performance hit can be
   minimised by making sure that the fields are *always* at the end
   of the commit message.

d. Using the proposed origin header in the standard commit header has
   close to zero overhead (in most commits the field is not present), yet
   codecomplexitywise it is almost identical with the Origin: field at
   the end of the commit message.

I find it remarkable though that people are dragging their feet at
solution d, yet are quite ok with solution c.  IMO solution c and d are
almost identical, except that solution c is ugly, and solution d is
elegant.  But if it makes it easier to prove the usefulness by
implementing the ugly solution first, that's fine.
-- 
Sincerely,
           Stephen R. van den Berg.
"There are three types of people in the world;
 those who can count, and those who can't."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 6:22 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Tue Sep 9, 6:38 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 6:48 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 7:04 am)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Tue Sep 9, 8:44 am)
Re: [RFC] origin link for cherry-pick and revert, Steven Grimm, (Tue Sep 9, 9:38 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 12:43 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Tue Sep 9, 12:59 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 1:25 pm)
Re: [RFC] origin link for cherry-pick and revert, Junio C Hamano, (Tue Sep 9, 1:42 pm)
Re: [RFC] origin link for cherry-pick and revert, Shawn O. Pearce, (Tue Sep 9, 1:47 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Tue Sep 9, 1:50 pm)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Tue Sep 9, 1:54 pm)
Re: [RFC] origin link for cherry-pick and revert, Junio C Hamano, (Tue Sep 9, 2:05 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Tue Sep 9, 2:09 pm)
Re: [RFC] origin link for cherry-pick and revert, Petr Baudis, (Tue Sep 9, 2:13 pm)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Tue Sep 9, 3:35 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 3:56 pm)
Re: [RFC] origin link for cherry-pick and revert, Petr Baudis, (Tue Sep 9, 4:05 pm)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Tue Sep 9, 4:07 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 4:08 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 4:32 pm)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Tue Sep 9, 4:35 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 4:36 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 4:58 pm)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Tue Sep 9, 4:59 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 5:13 pm)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Tue Sep 9, 5:23 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Tue Sep 9, 10:42 pm)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 1:10 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 1:30 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 1:45 am)
Re: [RFC] origin link for cherry-pick and revert, and more ..., Stephen R. van den Berg, (Wed Sep 10, 4:49 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Wed Sep 10, 5:21 am)
Re: [RFC] origin link for cherry-pick and revert, and more ..., Stephen R. van den Berg, (Wed Sep 10, 6:14 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 7:16 am)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Wed Sep 10, 8:10 am)
Re: [RFC] origin link for cherry-pick and revert, and more ..., Stephen R. van den Berg, (Wed Sep 10, 8:15 am)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Wed Sep 10, 8:30 am)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Wed Sep 10, 8:32 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 8:37 am)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Wed Sep 10, 8:43 am)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Wed Sep 10, 8:46 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 8:57 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Wed Sep 10, 9:18 am)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Wed Sep 10, 9:23 am)
Re: [RFC] origin link for cherry-pick and revert, Petr Baudis, (Wed Sep 10, 9:40 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 10:58 am)
Re: [RFC] origin link for cherry-pick and revert, Miklos Vajna, (Wed Sep 10, 1:32 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Wed Sep 10, 1:55 pm)
Re: [RFC] origin link for cherry-pick and revert, Miklos Vajna, (Wed Sep 10, 2:06 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 2:50 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Wed Sep 10, 2:54 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 3:34 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 3:44 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Wed Sep 10, 3:55 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 4:09 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 4:15 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 4:19 pm)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Wed Sep 10, 5:39 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Wed Sep 10, 7:46 pm)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Wed Sep 10, 10:16 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Wed Sep 10, 11:22 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 12:55 am)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Thu Sep 11, 1:20 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Thu Sep 11, 1:45 am)
Re: [RFC] origin link for cherry-pick and revert, A Large Angry SCM, (Thu Sep 11, 5:28 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 5:31 am)
Re: [RFC] origin link for cherry-pick and revert, A Large Angry SCM, (Thu Sep 11, 5:33 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 5:39 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Thu Sep 11, 6:51 am)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 8:02 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 8:32 am)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Thu Sep 11, 8:39 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 9:00 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Thu Sep 11, 9:01 am)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Thu Sep 11, 9:23 am)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Thu Sep 11, 9:53 am)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 10:02 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Thu Sep 11, 11:00 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 11:44 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 12:03 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 12:23 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 12:33 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 12:44 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 12:45 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 12:55 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 1:00 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 1:03 pm)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Thu Sep 11, 1:04 pm)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Thu Sep 11, 1:05 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 1:16 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 1:22 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 1:24 pm)
Re: [RFC] origin link for cherry-pick and revert, Nicolas Pitre, (Thu Sep 11, 1:27 pm)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Thu Sep 11, 2:01 pm)
Re: [RFC] origin link for cherry-pick and revert, Junio C Hamano, (Thu Sep 11, 2:05 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Thu Sep 11, 2:46 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 3:32 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 3:40 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 3:56 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Thu Sep 11, 4:01 pm)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Thu Sep 11, 4:10 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 4:17 pm)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Thu Sep 11, 4:26 pm)
Re: [RFC] origin link for cherry-pick and revert, Sam Vilain, (Thu Sep 11, 4:28 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 4:36 pm)
Re: [RFC] origin link for cherry-pick and revert, Linus Torvalds, (Thu Sep 11, 4:44 pm)
Re: [RFC] origin link for cherry-pick and revert, A Large Angry SCM, (Thu Sep 11, 5:03 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 5:13 pm)
Re: [RFC] origin link for cherry-pick and revert, A Large Angry SCM, (Thu Sep 11, 5:30 pm)
Re: [RFC] origin link for cherry-pick and revert, Sam Vilain, (Thu Sep 11, 7:24 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 10:39 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 10:47 pm)
Re: [RFC] origin link for cherry-pick and revert, Rogan Dawes, (Thu Sep 11, 11:19 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Thu Sep 11, 11:56 pm)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Fri Sep 12, 1:40 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Fri Sep 12, 1:50 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Fri Sep 12, 7:58 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Fri Sep 12, 8:05 am)
Re: [RFC] origin link for cherry-pick and revert, Jakub Narebski, (Fri Sep 12, 8:11 am)
Re: [RFC] origin link for cherry-pick and revert, Paolo Bonzini, (Fri Sep 12, 8:40 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Fri Sep 12, 8:54 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Fri Sep 12, 9:00 am)
Re: [RFC] origin link for cherry-pick and revert, Jeff King, (Fri Sep 12, 9:19 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Fri Sep 12, 9:43 am)
Re: [RFC] origin link for cherry-pick and revert, Theodore Tso, (Fri Sep 12, 11:44 am)
Re: [RFC] origin link for cherry-pick and revert, Stephen R. van den Berg, (Fri Sep 12, 1:56 pm)