On Tue, Sep 09, 2008 at 01:27:09AM -0700, Junio C Hamano wrote:

quoted text
> +struct extra_have_objects {
> +	int nr, alloc;
> +	unsigned char (*array)[20];
> +};

This declaration made me double-take. I think it is correct, and you are
saving an extra pointer over a malloc. But the syntax ends up a little
confusing:

        hashcpy(&(extra->array[extra->nr][0]), sha1);

Using a struct probably would have been a little easier to read. I don't
know if this is worth changing.

quoted text
> +	if (extra->alloc <= extra->nr)
> +		ALLOC_GROW(extra->array, extra->nr + 1, extra->alloc);

Isn't the conditional superfluous (ALLOC_GROW already makes this check)?

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html