Re: [PATCH v2] builtin-branch: improve output when displaying remote branches | KernelTrap

Re: [PATCH v2] builtin-branch: improve output when displaying remote branches

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jay Soffian

Subject: Re: [PATCH v2] builtin-branch: improve output when displaying remote branches

Date: Friday, February 13, 2009 - 1:06 am

On Fri, Feb 13, 2009 at 2:52 AM, Junio C Hamano <gitster@pobox.com> wrote:
quoted text> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> This strikes me as premature optimization.
>
> It is *not* an optimization.  It is reduction of code duplication to
> improve maintainability before copy-and-paste gets out of hand.
>
> The proper adjective for it is not "premature" but "preemptive".

I'll re-roll the patch again. However, if you look at the rest of
builtin-branch.c, you'll see there are more places than that which are
structured similarly (e.g. delete_branches). So if someone wanted to
add another branch type, that would be the time (IMO), to refactor the
statement at the top of append_ref().

j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] builtin-branch: improve output when displaying rem ..., Jay Soffian, (Tue Feb 10, 4:01 am)

Re: [PATCH] builtin-branch: improve output when displaying ..., Jay Soffian, (Tue Feb 10, 11:47 pm)

Re: [PATCH] builtin-branch: improve output when displaying ..., Junio C Hamano, (Wed Feb 11, 8:49 pm)

Re: [PATCH] builtin-branch: improve output when displaying ..., Jay Soffian, (Wed Feb 11, 9:30 pm)

Re: [PATCH] builtin-branch: improve output when displaying ..., Junio C Hamano, (Wed Feb 11, 10:42 pm)

[PATCH v2] builtin-branch: improve output when displaying ..., Jay Soffian, (Thu Feb 12, 10:34 pm)

Re: [PATCH v2] builtin-branch: improve output when display ..., Junio C Hamano, (Thu Feb 12, 11:35 pm)

Re: [PATCH v2] builtin-branch: improve output when display ..., Jay Soffian, (Thu Feb 12, 11:45 pm)

Re: [PATCH v2] builtin-branch: improve output when display ..., martin f krafft, (Thu Feb 12, 11:47 pm)

Re: [PATCH v2] builtin-branch: improve output when display ..., Junio C Hamano, (Fri Feb 13, 12:36 am)

Re: [PATCH v2] builtin-branch: improve output when display ..., Johannes Sixt, (Fri Feb 13, 12:37 am)

Re: [PATCH v2] builtin-branch: improve output when display ..., Junio C Hamano, (Fri Feb 13, 12:52 am)

Re: [PATCH v2] builtin-branch: improve output when display ..., Jay Soffian, (Fri Feb 13, 1:06 am)

[PATCH v3] builtin-branch: improve output when displaying ..., Jay Soffian, (Fri Feb 13, 2:40 am)