Re: [PATCH 04/14] msvc: Fix macro redefinition warnings

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Johannes Sixt
Date: Saturday, December 4, 2010 - 2:04 pm

On Samstag, 4. Dezember 2010, Ramsay Jones wrote:

Instead of removing the macros, wouldn't we be much safer with just

#ifndef S_IWUSR

? I suggest S_IWUSR because it is used inside #ifdef WIN32 brackets in 
test-chmtime.c and seems to be more important than the others :-)


-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 04/14] msvc: Fix macro redefinition warnings, Ramsay Jones, (Sat Dec 4, 12:00 pm)
Re: [PATCH 04/14] msvc: Fix macro redefinition warnings, Johannes Sixt, (Sat Dec 4, 2:04 pm)
Re: [PATCH 04/14] msvc: Fix macro redefinition warnings, Sebastian Schuberth, (Wed Dec 8, 3:32 am)
Re: [PATCH 04/14] msvc: Fix macro redefinition warnings, Johannes Sixt, (Wed Dec 8, 12:51 pm)