Re: [RFC/PATCH 5/6] revert: add --ff option to allow fast forward when cherry-picking

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Paolo Bonzini
Date: Monday, February 1, 2010 - 4:10 am

> +		OPT_BOOLEAN(0, "ff",&ff_ok, "allow fast forward"),

Why should this not be the default?  Instead, you'd add --no-ff.  This 
would simplify 6/6 further, like

   eval sha1=\$$#
   ...
   output git cherry-pick "$@"

Paolo
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC/PATCH 0/6] add --ff option to cherry-pick, Christian Couder, (Mon Feb 1, 12:55 am)
[RFC/PATCH 3/6] reset: refactor reseting in its own function, Christian Couder, (Mon Feb 1, 12:55 am)
[RFC/PATCH 4/6] reset: make reset function non static and ..., Christian Couder, (Mon Feb 1, 12:55 am)
[RFC/PATCH 6/6] rebase -i: use new --ff cherry-pick option, Christian Couder, (Mon Feb 1, 12:55 am)
Re: [RFC/PATCH 1/6] revert: libify cherry-pick and revert ..., Johannes Schindelin, (Mon Feb 1, 3:26 am)
Re: [RFC/PATCH 5/6] revert: add --ff option to allow fast ..., Paolo Bonzini, (Mon Feb 1, 4:10 am)
Re: [RFC/PATCH 5/6] revert: add --ff option to allow fast ..., Christian Couder, (Mon Feb 1, 10:13 pm)