Re: [PATCH v6 12/13] notes: track whether notes_trees were changed at all | KernelTrap

Re: [PATCH v6 12/13] notes: track whether notes_trees were changed at all

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Johan Herland

Subject: Re: [PATCH v6 12/13] notes: track whether notes_trees were changed at all

Date: Thursday, March 11, 2010 - 3:58 am

On Wednesday 10 March 2010, Thomas Rast wrote:
quoted text> Currently, the notes copying is a bit wasteful since it always creates
> new trees, even if no notes were copied at all.
> 
> Teach add_note() and remove_note() to flag the affected notes tree as
> changed ('dirty').  Then teach builtin/notes.c to use this knowledge
> and avoid committing trees that weren't changed.
> 
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>

Acked-by: Johan Herland <johan@herland.net>


-- 
Johan Herland, <johan@herland.net>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC PATCH 0/6] post-rewrite hook and copying notes, Thomas Rast, (Sun Feb 14, 9:17 am)

[RFC PATCH 1/6] Documentation: document post-rewrite hook, Thomas Rast, (Sun Feb 14, 9:17 am)

[RFC PATCH 3/6] filter-branch: invoke post-rewrite hook, Thomas Rast, (Sun Feb 14, 9:17 am)

[RFC PATCH 4/6] rebase: invoke post-rewrite hook, Thomas Rast, (Sun Feb 14, 9:17 am)

[RFC PATCH 5/6] rebase -i: invoke post-rewrite hook, Thomas Rast, (Sun Feb 14, 9:17 am)

[RFC PATCH 6/6] contrib: add a hook that copies notes over ..., Thomas Rast, (Sun Feb 14, 9:17 am)

Re: [RFC PATCH 6/6] contrib: add a hook that copies notes ..., Thomas Rast, (Sun Feb 14, 9:21 am)

[PATCH] WIP: git notes copy --stdin, Thomas Rast, (Sun Feb 14, 2:46 pm)

Re: [PATCH] WIP: git notes copy --stdin, Johan Herland, (Sun Feb 14, 6:25 pm)

Re: [RFC PATCH 3/6] filter-branch: invoke post-rewrite hook, Johannes Sixt, (Mon Feb 15, 1:36 pm)

[RFC PATCH v2 00/11] post-rewrite / automatic notes copying, Thomas Rast, (Tue Feb 16, 4:25 pm)

[RFC PATCH v2 01/11] Documentation: document post-rewrite hook, Thomas Rast, (Tue Feb 16, 4:25 pm)

[RFC PATCH v2 02/11] commit --amend: invoke post-rewrite hook, Thomas Rast, (Tue Feb 16, 4:25 pm)

[RFC PATCH v2 03/11] rebase: invoke post-rewrite hook, Thomas Rast, (Tue Feb 16, 4:25 pm)

[RFC PATCH v2 04/11] rebase -i: invoke post-rewrite hook, Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 05/11] notes: clean up t3301, Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 06/11] notes: implement 'git notes copy --stdin', Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 07/11] notes: implement helpers needed for n ..., Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 08/11] rebase: support automatic notes copying, Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 09/11] commit --amend: copy notes to the new ..., Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 10/11] filter-branch: invoke post-rewrite hook, Thomas Rast, (Tue Feb 16, 4:26 pm)

[RFC PATCH v2 11/11] filter-branch: learn how to filter notes, Thomas Rast, (Tue Feb 16, 4:26 pm)

Re: [RFC PATCH v2 05/11] notes: clean up t3301, Junio C Hamano, (Tue Feb 16, 4:52 pm)

Re: [RFC PATCH v2 07/11] notes: implement helpers needed f ..., Junio C Hamano, (Tue Feb 16, 4:58 pm)

Re: [RFC PATCH v2 01/11] Documentation: document post-rewr ..., Junio C Hamano, (Tue Feb 16, 4:59 pm)

Re: [RFC PATCH v2 07/11] notes: implement helpers needed f ..., Thomas Rast, (Tue Feb 16, 5:09 pm)

Re: [RFC PATCH v2 07/11] notes: implement helpers needed f ..., Junio C Hamano, (Tue Feb 16, 5:18 pm)

Re: [RFC PATCH v2 01/11] Documentation: document post-rewr ..., Thomas Rast, (Tue Feb 16, 5:18 pm)

Re: [RFC PATCH v2 01/11] Documentation: document post-rewr ..., Junio C Hamano, (Tue Feb 16, 5:29 pm)

Re: [RFC PATCH v2 11/11] filter-branch: learn how to filte ..., Johannes Sixt, (Wed Feb 17, 12:59 pm)

Re: [RFC PATCH v2 11/11] filter-branch: learn how to filte ..., Thomas Rast, (Wed Feb 17, 4:06 pm)

[WIP/RFC PATCH] Support showing notes from more than one n ..., Thomas Rast, (Sat Feb 20, 7:58 am)

Re: [WIP/RFC PATCH] Support showing notes from more than o ..., Thomas Rast, (Sat Feb 20, 8:23 am)

[RFC PATCH v3 00/12] several notes refs, post-rewrite, not ..., Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 01/12] Support showing notes from more than ..., Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 02/12] Documentation: document post-rewrite hook, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 03/12] commit --amend: invoke post-rewrite hook, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 04/12] rebase: invoke post-rewrite hook, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 05/12] rebase -i: invoke post-rewrite hook, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 06/12] notes: implement 'git notes copy --stdin', Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 07/12] notes: implement helpers needed for n ..., Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 08/12] rebase: support automatic notes copying, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 09/12] commit --amend: copy notes to the new ..., Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 10/12] filter-branch: invoke post-rewrite hook, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 11/12] filter-branch: learn how to filter notes, Thomas Rast, (Sat Feb 20, 3:16 pm)

[RFC PATCH v3 12/12] notes: add shorthand --ref to overrid ..., Thomas Rast, (Sat Feb 20, 3:16 pm)

Re: [RFC PATCH v3 01/12] Support showing notes from more t ..., Junio C Hamano, (Sat Feb 20, 8:06 pm)

Re: [RFC PATCH v3 03/12] commit --amend: invoke post-rewri ..., Junio C Hamano, (Sat Feb 20, 8:12 pm)

Re: [RFC PATCH v3 06/12] notes: implement 'git notes copy ..., Junio C Hamano, (Sat Feb 20, 8:31 pm)

Re: [RFC PATCH v3 07/12] notes: implement helpers needed f ..., Junio C Hamano, (Sat Feb 20, 8:34 pm)

Re: [RFC PATCH v3 00/12] several notes refs, post-rewrite, ..., Junio C Hamano, (Sat Feb 20, 8:47 pm)

Re: [RFC PATCH v3 00/12] several notes refs, post-rewrite, ..., Thomas Rast, (Sat Feb 20, 11:14 pm)

[PATCH v4 00/11] several notes refs, post-rewrite, notes r ..., Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 01/11] test-lib: unset GIT_NOTES_REF to stop it ..., Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 02/11] Support showing notes from more than one ..., Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 03/11] Documentation: document post-rewrite hook, Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 04/11] commit --amend: invoke post-rewrite hook, Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 05/11] rebase: invoke post-rewrite hook, Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 06/11] rebase -i: invoke post-rewrite hook, Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 07/11] notes: implement 'git notes copy --stdin', Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 08/11] notes: implement helpers needed for note ..., Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 09/11] rebase: support automatic notes copying, Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 10/11] commit --amend: copy notes to the new commit, Thomas Rast, (Sun Feb 21, 5:10 pm)

[PATCH v4 11/11] notes: add shorthand --ref to override GI ..., Thomas Rast, (Sun Feb 21, 5:10 pm)

Re: [RFC PATCH v3 00/12] several notes refs, post-rewrite, ..., Junio C Hamano, (Sun Feb 21, 5:18 pm)

Re: [PATCH v4 00/11] several notes refs, post-rewrite, not ..., Junio C Hamano, (Sun Feb 21, 5:25 pm)

Re: [PATCH v4 00/11] several notes refs, post-rewrite, not ..., Thomas Rast, (Sun Feb 21, 5:32 pm)

Re: [PATCH v4 02/11] Support showing notes from more than ..., Junio C Hamano, (Mon Feb 22, 4:20 pm)

Re: [PATCH v4 02/11] Support showing notes from more than ..., Thomas Rast, (Mon Feb 22, 4:25 pm)

Re: [PATCH v4 02/11] Support showing notes from more than ..., Junio C Hamano, (Mon Feb 22, 5:21 pm)

[PATCH v5 00/11] several notes refs, post-rewrite, notes r ..., Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 01/11] test-lib: unset GIT_NOTES_REF to stop it ..., Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 02/11] Support showing notes from more than one ..., Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 03/11] Documentation: document post-rewrite hook, Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 04/11] commit --amend: invoke post-rewrite hook, Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 05/11] rebase: invoke post-rewrite hook, Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 06/11] rebase -i: invoke post-rewrite hook, Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 07/11] notes: implement 'git notes copy --stdin', Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 08/11] notes: implement helpers needed for note ..., Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 09/11] rebase: support automatic notes copying, Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 10/11] commit --amend: copy notes to the new commit, Thomas Rast, (Mon Feb 22, 5:42 pm)

[PATCH v5 11/11] notes: add shorthand --ref to override GI ..., Thomas Rast, (Mon Feb 22, 5:42 pm)

Re: [PATCH v5 00/11] several notes refs, post-rewrite, not ..., Junio C Hamano, (Mon Feb 22, 5:49 pm)

Re: [PATCH v5 00/11] several notes refs, post-rewrite, not ..., Thomas Rast, (Mon Feb 22, 5:49 pm)

Re: [PATCH v5 02/11] Support showing notes from more than ..., Junio C Hamano, (Mon Feb 22, 6:47 pm)

Re: [PATCH v5 02/11] Support showing notes from more than ..., Thomas Rast, (Tue Feb 23, 10:10 am)

[PATCH] format-patch: learn to fill comment section of ema ..., Thomas Rast, (Tue Feb 23, 10:34 am)

[PATCH] BROKEN -- format-patch: learn to fill comment sect ..., Thomas Rast, (Tue Feb 23, 10:34 am)

Re: [PATCH] BROKEN -- format-patch: learn to fill comment ..., Thomas Rast, (Tue Feb 23, 10:37 am)

Re: [PATCH] format-patch: learn to fill comment section of ..., Junio C Hamano, (Tue Feb 23, 2:56 pm)

Re: [PATCH v5 06/11] rebase -i: invoke post-rewrite hook, Junio C Hamano, (Tue Feb 23, 11:15 pm)

Re: [PATCH] BROKEN -- format-patch: learn to fill comment ..., Stephen Boyd, (Wed Feb 24, 12:45 am)

Re: [PATCH v5 09/11] rebase: support automatic notes copying, Junio C Hamano, (Wed Feb 24, 8:58 pm)

[PATCH v6 00/13] several notes refs, post-rewrite, notes r ..., Thomas Rast, (Wed Mar 10, 7:03 am)

[PATCH v6 01/13] test-lib: unset GIT_NOTES_REF to stop it ..., Thomas Rast, (Wed Mar 10, 7:03 am)

[PATCH v6 02/13] Support showing notes from more than one ..., Thomas Rast, (Wed Mar 10, 7:03 am)

[PATCH v6 03/13] Documentation: document post-rewrite hook, Thomas Rast, (Wed Mar 10, 7:03 am)

[PATCH v6 04/13] commit --amend: invoke post-rewrite hook, Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 05/13] rebase: invoke post-rewrite hook, Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 06/13] rebase -i: invoke post-rewrite hook, Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 07/13] notes: implement 'git notes copy --stdin', Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 08/13] notes: implement helpers needed for note ..., Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 09/13] rebase: support automatic notes copying, Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 10/13] commit --amend: copy notes to the new commit, Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 11/13] notes: add shorthand --ref to override GI ..., Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 12/13] notes: track whether notes_trees were cha ..., Thomas Rast, (Wed Mar 10, 7:05 am)

[PATCH v6 13/13] git-notes(1): add a section about the mea ..., Thomas Rast, (Wed Mar 10, 7:06 am)

Re: [PATCH] format-patch: learn to fill comment section of ..., Thomas Rast, (Wed Mar 10, 7:08 am)

Re: [PATCH v6 00/13] several notes refs, post-rewrite, not ..., Junio C Hamano, (Wed Mar 10, 2:23 pm)

Re: [PATCH v6 01/13] test-lib: unset GIT_NOTES_REF to stop ..., Johan Herland, (Thu Mar 11, 1:55 am)

Re: [PATCH v6 02/13] Support showing notes from more than ..., Johan Herland, (Thu Mar 11, 3:03 am)

Re: [PATCH v6 07/13] notes: implement 'git notes copy --stdin', Johan Herland, (Thu Mar 11, 3:30 am)

Re: [PATCH v6 08/13] notes: implement helpers needed for n ..., Johan Herland, (Thu Mar 11, 3:50 am)

Re: [PATCH v6 11/13] notes: add shorthand --ref to overrid ..., Johan Herland, (Thu Mar 11, 3:56 am)

Re: [PATCH v6 12/13] notes: track whether notes_trees were ..., Johan Herland, (Thu Mar 11, 3:58 am)

Re: [PATCH v6 13/13] git-notes(1): add a section about the ..., Johan Herland, (Thu Mar 11, 3:59 am)

[PATCH v7 00/13] tr/display-notes, Thomas Rast, (Fri Mar 12, 10:04 am)

[PATCH v7 03/13] Documentation: document post-rewrite hook, Thomas Rast, (Fri Mar 12, 10:04 am)

[PATCH v7 06/13] rebase -i: invoke post-rewrite hook, Thomas Rast, (Fri Mar 12, 10:04 am)

[PATCH v7 13/13] git-notes(1): add a section about the mea ..