Re: [PATCH] Make xmalloc and xrealloc thread-safe

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Fredrik Kuivinen

Subject: Re: [PATCH] Make xmalloc and xrealloc thread-safe

Date: Tuesday, March 30, 2010 - 11:57 pm

On Sat, Mar 27, 2010 at 19:59, Nicolas Pitre <nico@fluxnic.net> wrote:
quoted text> On Sat, 27 Mar 2010, Fredrik Kuivinen wrote:
>
>> On Wed, Mar 24, 2010 at 21:22, Nicolas Pitre <nico@fluxnic.net> wrote:
>> > +static void try_to_free_from_threads(size_t size)
>> > +{
>> > +       read_lock();
>> > +       release_pack_memory(size, -1);
>> > +       read_unlock();
>> > +}
>> > +
>>
>> Will this really work in all cases? In the find_deltas -> try_delta ->
>> read_sha1_file -> ... -> xmalloc call path, the mutex is already
>> locked when we get to xmalloc.
>
> You're right.  Damn.

A simple fix is to make it a recursive mutex instead. This will work
with a minimal change in win32 as well as the CRITICAL_SECTION type is
recursive.

I guess the downside is that the locking potentially gets slightly slower.


- Fredrik
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/2] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Tue Mar 23, 10:31 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Shawn O. Pearce, (Tue Mar 23, 11:43 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Tue Mar 23, 2:21 pm)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Tue Mar 23, 4:50 pm)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Wed Mar 24, 8:23 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Mar 24, 10:53 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Shawn Pearce, (Wed Mar 24, 11:22 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Junio C Hamano, (Wed Mar 24, 11:44 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Mar 24, 11:54 am)

Re: [PATCH 1/2] Make xmalloc and xrealloc thread-safe, Shawn Pearce, (Wed Mar 24, 12:57 pm)

[PATCH] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Mar 24, 1:22 pm)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Shawn O. Pearce, (Wed Mar 24, 1:28 pm)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Mar 24, 2:02 pm)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Junio C Hamano, (Wed Mar 24, 2:11 pm)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Junio C Hamano, (Wed Mar 24, 2:28 pm)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Sat Mar 27, 6:26 am)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Sat Mar 27, 11:59 am)

Re: [PATCH] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Tue Mar 30, 11:57 pm)

[PATCH v2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Tue Apr 6, 7:57 pm)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Shawn O. Pearce, (Tue Apr 6, 8:16 pm)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Tue Apr 6, 9:51 pm)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Junio C Hamano, (Tue Apr 6, 10:21 pm)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Shawn Pearce, (Wed Apr 7, 5:29 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Apr 7, 6:17 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Shawn Pearce, (Wed Apr 7, 7:30 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Wed Apr 7, 7:45 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Apr 7, 7:47 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Apr 7, 8:08 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Sverre Rabbelier, (Wed Apr 7, 8:27 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Wed Apr 7, 9:13 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Fredrik Kuivinen, (Wed Apr 7, 9:15 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Junio C Hamano, (Wed Apr 7, 9:17 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Erik Faye-Lund, (Wed Apr 7, 9:44 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Nicolas Pitre, (Wed Apr 7, 11:37 am)

Re: [PATCH v2] Make xmalloc and xrealloc thread-safe, Johannes Sixt, (Wed Apr 7, 11:49 am)

[PATCH] Thread-safe xmalloc and xrealloc needs a recursive ..., Johannes Sixt, (Thu Apr 8, 12:15 am)

Re: [PATCH] Thread-safe xmalloc and xrealloc needs a recur ..., Fredrik Kuivinen, (Thu Apr 8, 1:42 am)