Re: [PATCH/RFC v2 1/4] Add "core.eolStyle" variable to control end-of-line conversion

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dmitry Potapov
Date: Monday, May 10, 2010 - 7:03 am

On Mon, May 10, 2010 at 09:25:11AM -0400, Robert Buck wrote:

It looks like you set core.autocrlf to true on Linux.

The problem is core.autocrlf says two things -- whether you want to
enable automatic eol conversion for text files and whether you have CRLF
for text files. Only if the answer is "yes" to both then you should set
it to true. In other words, you should never set it to true on Linux.

You may want use core.autocrlf=input on Linux to avoid text files being
accidentally commit with a wrong encoding, when they were copied from
Windows directly.


Yes, we want to have a separate setting, whihc will tell what is EOL on
your system, and it should have sensible default, i.e. LF on Linux and
CRLF on Windows.


Dmitry
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH/RFC v2 0/4] End-of-line normalization, take 2 (now ..., Eyvind Bernhardsen, (Sat May 8, 2:46 pm)
[PATCH/RFC v2 2/4] Add tests for per-repository eol normal ..., Eyvind Bernhardsen, (Sat May 8, 2:46 pm)
[PATCH/RFC v2 3/4] Pass eol conv mode as an argument inste ..., Eyvind Bernhardsen, (Sat May 8, 2:46 pm)
[PATCH/RFC v2 4/4] Add per-repository eol normalization, Eyvind Bernhardsen, (Sat May 8, 2:46 pm)