[PATCH] gitattributes.txt: mention exceptions to gitignore rules

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?=
Date: Tuesday, January 4, 2011 - 6:31 am

gitattr and .gitignore are supposed to use the same rules for matching
patterns. Unfortunately it's not exactly the same in reality. Mention
the differences so users won't be surprised, until gitattr gets
updates.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 2011/1/4 Marcin Wiśnicki <mwisnicki@gmail.com>:
 > I think that for the time being at least the manual page must change to
 > reflect reality.

 Looks like changes will be more than just a few lines because path_matches()
 needs to learn about directories (iow less likely to get fixed right away).
 So, yes, good idea.

 I skimmed through excluded_from_list() (gitignore) and path_matches (gitattr).
 Seems no other differences.

 Documentation/gitattributes.txt |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index 5a7f936..cfaf107 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -56,6 +56,7 @@ When more than one pattern matches the path, a later line
 overrides an earlier line.  This overriding is done per
 attribute.  The rules how the pattern matches paths are the
 same as in `.gitignore` files; see linkgit:gitignore[5].
+However patterns that end with a slash is not supported.
 
 When deciding what attributes are assigned to a path, git
 consults `$GIT_DIR/info/attributes` file (which has the highest
-- 
1.7.3.4.878.g439c7

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] gitattributes.txt: mention exceptions to gitignore ..., =?UTF-8?q?Nguy=E1=BB ..., (Tue Jan 4, 6:31 am)
Re: [PATCH] gitattributes.txt: mention exceptions to gitig ..., Marcin =?iso-8859-2? ..., (Tue Jan 4, 8:40 am)
Re: [PATCH] gitattributes.txt: mention exceptions to gitig ..., Marcin =?iso-8859-2? ..., (Tue Jan 4, 2:17 pm)