Re: [RFC][PATCH] Journal superblock update should send a barrier

Previous thread: ext4 benchmark questions by Steve Brown on Thursday, April 22, 2010 - 2:38 pm. (8 messages)

Next thread: Benchmarking data from a raid machine 2.6.34-rc3 by Keith Mannthey on Friday, April 23, 2010 - 5:06 pm. (1 message)
From: Jan Kara
Date: Thursday, April 22, 2010 - 5:25 pm

Hi,

  while reading through the checkpointing code I've realized that we
actually have to send a barrier before each update of journal superblock
after checkpointing. Attached patch does this. Just I'm not sure whether
the performance cost won't be too big. In principle, we could make this
more lightweight by using the fact that transaction commit also sends the
barrier. So we could check before sending a barrier for transaction commit
whether we are slowly running out of journal space and if so whether some
transaction isn't already checkpointed. If yes, we can happily submit
update of journal superblock after the barrier. In case journal is decently
large this should solve the checkpointing problem without introducing
noticeable overhead...

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR
From: Jan Kara
Date: Friday, May 7, 2010 - 8:53 am

Ping? Ted, any opinion?


-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs
--

From: Jan Kara
Date: Wednesday, May 26, 2010 - 6:58 am

Did you have a chance to look at this?


-- 
Jan Kara <jack@suse.cz>
SuSE CR Labs
--

Previous thread: ext4 benchmark questions by Steve Brown on Thursday, April 22, 2010 - 2:38 pm. (8 messages)

Next thread: Benchmarking data from a raid machine 2.6.34-rc3 by Keith Mannthey on Friday, April 23, 2010 - 5:06 pm. (1 message)