In the original code the parenthesis are in the wrong position, so the conditions are always true. Signed-off-by: Dan Carpenter <error27@gmail.com> --- v2: white space changes. Compile tested only. diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 7016fdd..e19b932 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -3954,8 +3954,8 @@ void XGI_GetCRT2ResInfo(unsigned short ModeNo, unsigned short ModeIdIndex, ...

In the original code the parenthesis are in the wrong position, so the conditions are always true. Signed-off-by: Dan Carpenter <error27@gmail.com> --- Compile tested only. diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index 7016fdd..0d69a88 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -3954,7 +3954,7 @@ void XGI_GetCRT2ResInfo(unsigned short ModeNo, unsigned short ModeIdIndex, unsigned char ...

It does? The first check is the bogus one, surely. The queue is created and destroyed by scsi_alloc_sdev(), so queuedata can never be NULL for a SCSI queue. There's no check anywhere in the rest of SCSI, so there shouldn't be one here, should there? James --

It can be called for any queue so it returns NULL for a non-SCSI queue. If you think the queue scsi_dh_activate() is called on may be a non-scsi one, then you need to use scsi_device_from_queue() and check the result. Checking q->queuedata for NULL isn't sufficient because other devices are perfectly entitled to use q->queuedata for their own purposes. If you know you have a SCSI queue, you can just pick sdev out of q->queuedata. James --