Re: [PATCH] atomic.h : standardizing atomic primitives

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mathieu Desnoyers
Date: Wednesday, January 31, 2007 - 9:25 am

Hi Peter,

Thanks for testing Andrew's fixes. I am wondering about what happened to
the Powerpc recursive include problems Andrew experienced. Quoting him :

"OK, I fixed eight separate compile errors in this patch series and
now powerpc is being very ugly with a twisty maze of include
dependencies.

I'm giving up.  Someone should publish a suite of cross-compilers for us
so stuff like this doesn't need to happen."

I see that you have removed the include <asm/atomic.h> from bitops.h and
system.h in powerpc. If it compiles on every architectures, then it's a
good approach.

I planned to post a new patch which uses macros for cmpxchg and xchg in
asm-generic/atomic.h instead of inline functions. It would remove the
dependency on system.h. However, if your modifications work well on
every architecture, my fix might not be needed. Anyone has a preferred
solution ? I have not been able to setup my cross-compiler test bench
yet due to some hardware issues and waited for it before I released
further fixes, but if you want to try my macro-based fix, I could post
it.

And about the alpha build, Does the assembler errors also happen without
this patch ?

Regards,

Mathieu


* Peter Zijlstra (a.p.zijlstra@chello.nl) wrote:

-- 
OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/09] atomic.h : standardizing atomic primitives, Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 01/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 02/09] atomic.h : Complete atomic_long operations i ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 03/09] atomic.h : i386 type safety fix, Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 04/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 05/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 06/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 07/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 08/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH 09/09] atomic.h : Add atomic64 cmpxchg, xchg and ad ..., Mathieu Desnoyers, (Thu Jan 11, 6:35 pm)
[PATCH] atomic.h : standardizing atomic primitives, Peter Zijlstra, (Wed Jan 31, 8:28 am)
Re: [PATCH] atomic.h : standardizing atomic primitives, Mathieu Desnoyers, (Wed Jan 31, 9:25 am)
Re: [PATCH] atomic.h : standardizing atomic primitives, Peter Zijlstra, (Wed Jan 31, 9:36 am)