Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Jens Axboe

Subject: Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

Date: Monday, October 1, 2007 - 4:59 am

On Sun, Sep 30 2007, Grant Likely wrote:
quoted text> On 9/30/07, Christoph Hellwig <hch@infradead.org> wrote:
> > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote:
> > > +     if ((rc = platform_driver_register(&ace_platform_driver)) != 0)
> > > +             goto err_plat;
> >
> >         rc = platform_driver_register(&ace_platform_driver);
> >         if (rc)
> >                  goto err_plat;
> >
> > please.
> 
> Okay, will do.
> 
> >
> > > +      err_plat:
> > > +     unregister_blkdev(ace_major, "xsysace");
> > > +      err_blk:
> >
> > labels should be indented zero or one space, but not more.
> 
> scripts/Lindent does this.  Originally, I *didn't* have my labels
> indented.  :-)   Does Lindent need to be fixed?

Seems so, if it idents labels.

Just send a fixup patch for that, I'll add your series to the block tree
for 2.6.24.

-- 
Jens Axboe

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH v2 0/6] SystemACE: rework and of_platform bus bindi ..., Grant Likely, (Sun Sep 30, 3:56 pm)

[PATCH v2 1/6] Add Xilinx SystemACE entry to maintainers, Grant Likely, (Sun Sep 30, 3:57 pm)

[PATCH v2 2/6] Sysace: Use the established platform bus api, Grant Likely, (Sun Sep 30, 3:57 pm)

[PATCH v2 3/6] Sysace: Move structure allocation from bus ..., Grant Likely, (Sun Sep 30, 3:57 pm)

[PATCH v2 4/6] Sysace: minor rework and cleanup changes, Grant Likely, (Sun Sep 30, 3:57 pm)

[PATCH v2 5/6] Sysace: Move IRQ handler registration to oc ..., Grant Likely, (Sun Sep 30, 3:57 pm)

[PATCH v2 6/6] Sysace: Add of_platform_bus binding, Grant Likely, (Sun Sep 30, 3:57 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Christoph Hellwig, (Sun Sep 30, 4:05 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Grant Likely, (Sun Sep 30, 4:33 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Jens Axboe, (Mon Oct 1, 4:59 am)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Grant Likely, (Mon Oct 1, 6:17 am)

Re: [PATCH v2 5/6] Sysace: Move IRQ handler registration t ..., Benjamin Herrenschmidt, (Mon Oct 1, 10:55 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Benjamin Herrenschmidt, (Mon Oct 1, 10:58 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Jens Axboe, (Mon Oct 1, 11:35 pm)

Re: [PATCH v2 2/6] Sysace: Use the established platform bu ..., Grant Likely, (Tue Oct 2, 6:52 am)

Re: [PATCH v2 5/6] Sysace: Move IRQ handler registration t ..., Grant Likely, (Tue Oct 2, 6:57 am)