[PATCH 3/3] pciehp: hotplug: reinit hotplug h/w on resume from suspend

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mark Lord
Date: Wednesday, October 17, 2007 - 8:34 pm

(repost to conform with akpm's subject line conventions)

Make use of the previously split out pcie_init_enable_events() function
to reinitialize the hotplug hardware on resume from suspend,
but only when pciehp_force==1.  Otherwise behaviour is unmodified.

Signed-off-by: Mark Lord <mlord@pobox.com>
---
--- git12/drivers/pci/hotplug/pciehp_ctrl.c	2007-10-17 19:28:23.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_ctrl.c	2007-10-17 19:31:22.000000000 -0400
@@ -37,7 +37,6 @@
 #include "pciehp.h"
 
 static void interrupt_event_handler(struct work_struct *work);
-static int pciehp_disable_slot(struct slot *p_slot);
 
 static int queue_interrupt_event(struct slot *p_slot, u32 event_type)
 {
--- git12/drivers/pci/hotplug/pciehp.h	2007-10-17 19:28:23.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp.h	2007-10-17 19:32:03.000000000 -0400
@@ -162,6 +162,8 @@
 extern void pciehp_queue_pushbutton_work(struct work_struct *work);
 int pcie_init(struct controller *ctrl, struct pcie_device *dev);
 int pciehp_enable_slot(struct slot *p_slot);
+int pciehp_disable_slot(struct slot *p_slot);
+int pcie_init_hardware(struct controller *ctrl, struct pcie_device *dev);
 
 static inline struct slot *pciehp_find_slot(struct controller *ctrl, u8 device)
 {
--- git12/drivers/pci/hotplug/pciehp_core.c	2007-10-17 19:28:23.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_core.c	2007-10-17 19:33:05.000000000 -0400
@@ -510,6 +510,24 @@
 static int pciehp_resume (struct pcie_device *dev)
 {
 	printk("%s ENTRY\n", __FUNCTION__);
+	if (pciehp_force) {
+		struct pci_dev *pdev = dev->port;
+		struct controller *ctrl = pci_get_drvdata(pdev);
+		struct slot *t_slot;
+		u8 status;
+
+		/* reinitialize the chipset's event detection logic */
+		pcie_init_hardware(ctrl, dev);
+
+		t_slot = pciehp_find_slot(ctrl, ctrl->slot_device_offset);
+
+		/* Check if slot is occupied */
+		t_slot->hpc_ops->get_adapter_status(t_slot, &status);
+		if (status)
+			pciehp_enable_slot(t_slot);
+		else
+			pciehp_disable_slot(t_slot);
+	}
 	return 0;
 }
 #endif
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/3] Fix two PEIe hotplug issues, Mark Lord, (Wed Oct 17, 7:57 pm)
Re: [PATCH 1/3] pciehp_handle_preinserted_card, Mark Lord, (Wed Oct 17, 7:59 pm)
Re: [PATCH 2/3] pciehp_split_pcie_init, Mark Lord, (Wed Oct 17, 8:00 pm)
[PATCH 3/3] pciehp_resume_reinit_hardware, Mark Lord, (Wed Oct 17, 8:02 pm)
[PATCH 1/3] pciehp_handle_preinserted_card, Mark Lord, (Wed Oct 17, 8:03 pm)
[PATCH 2/3] pciehp_split_pcie_init, Mark Lord, (Wed Oct 17, 8:04 pm)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Mark Lord, (Wed Oct 17, 8:05 pm)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Mark Lord, (Wed Oct 17, 8:09 pm)
[PATCH 3/3] pciehp: hotplug: reinit hotplug h/w on resume ..., Mark Lord, (Wed Oct 17, 8:34 pm)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Kristen Carlson Accardi, (Thu Oct 18, 9:13 am)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Kristen Carlson Accardi, (Thu Oct 18, 10:06 am)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Mark Lord, (Thu Oct 18, 10:06 am)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Theodore Tso, (Thu Oct 18, 10:49 am)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Kristen Carlson Accardi, (Thu Oct 18, 10:56 am)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Mark Lord, (Thu Oct 18, 2:11 pm)
Re: [PATCH 0/3] Fix two PEIe hotplug issues, Mark Lord, (Thu Oct 18, 2:26 pm)
[PATCH] Fix PCIe double initialization bug, Mark Lord, (Sat Nov 17, 5:27 pm)
Re: [PATCH] Fix PCIe double initialization bug, Rafael J. Wysocki, (Sun Nov 18, 5:23 am)
Re: [PATCH] Fix PCIe double initialization bug, Mark Lord, (Sun Nov 18, 7:37 am)