Re: [PATCH 09/10] Change table chaining layout

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Linus Torvalds

Subject: Re: [PATCH 09/10] Change table chaining layout

Date: Wednesday, October 24, 2007 - 8:16 am

On Wed, 24 Oct 2007, Jens Axboe wrote:
quoted text> > 
> > As it no longer sets the page only, perhaps it's a good idea to rename
> > sg_set_page() to sg_set()?
> 
> sg_set_buf() also sets length and offset, sg_set_page() is just a mirror
> of that. So I'd prefer to keep the naming.

I agree. And it's not like you can get it wrong, since if you only give 
the "page" argument, the preprocessor will complain loudly.

I think "sg_set_x()" is now rather logical - we fill in the SG entry 
(entirely), and the only question is _how_ we do it (which is what "x" 
says - using a page, or a kernel buffer).

		Linus
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/10] SG updates, Jens Axboe, (Mon Oct 22, 11:10 am)

[PATCH 01/10] [SG] Add helpers for manipulating SG entries, Jens Axboe, (Mon Oct 22, 11:10 am)

[PATCH 02/10] [SG] Update block layer to use sg helpers, Jens Axboe, (Mon Oct 22, 11:10 am)

[PATCH 03/10] [SG] Update crypto/ to sg helpers, Jens Axboe, (Mon Oct 22, 11:10 am)

[PATCH 04/10] [SG] Update drivers to use sg helpers, Jens Axboe, (Mon Oct 22, 11:10 am)

[PATCH 05/10] [SG] Update fs/ to use sg helpers, Jens Axboe, (Mon Oct 22, 11:10 am)

[PATCH 06/10] [SG] Update net/ to use sg helpers, Jens Axboe, (Mon Oct 22, 11:11 am)

[PATCH 07/10] [SG] Update swiotlb to use sg helpers, Jens Axboe, (Mon Oct 22, 11:11 am)

[PATCH 08/10] [SG] Update arch/ to use sg helpers, Jens Axboe, (Mon Oct 22, 11:11 am)

[PATCH 09/10] Change table chaining layout, Jens Axboe, (Mon Oct 22, 11:11 am)

[PATCH 10/10] Add CONFIG_DEBUG_SG sg validation, Jens Axboe, (Mon Oct 22, 11:11 am)

Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Mon Oct 22, 12:39 pm)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Mon Oct 22, 12:49 pm)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Mon Oct 22, 12:52 pm)

Re: [PATCH 09/10] Change table chaining layout, Alan Cox, (Mon Oct 22, 1:16 pm)

Re: [PATCH 09/10] Change table chaining layout, Matt Mackall, (Mon Oct 22, 1:38 pm)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Mon Oct 22, 1:44 pm)

Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers, Benny Halevy, (Mon Oct 22, 2:10 pm)

Re: [PATCH 09/10] Change table chaining layout, Benny Halevy, (Mon Oct 22, 2:16 pm)

Re: [PATCH 09/10] Change table chaining layout, Jeff Garzik, (Mon Oct 22, 2:21 pm)

Re: [PATCH 09/10] Change table chaining layout, Alan Cox, (Mon Oct 22, 2:43 pm)

Re: [PATCH 09/10] Change table chaining layout, Matt Mackall, (Mon Oct 22, 2:47 pm)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Mon Oct 22, 2:47 pm)

Re: [PATCH 09/10] Change table chaining layout, Alan Cox, (Mon Oct 22, 3:52 pm)

Re: [PATCH 09/10] Change table chaining layout, Matt Mackall, (Mon Oct 22, 4:46 pm)

Re: [PATCH 09/10] Change table chaining layout, David Miller, (Mon Oct 22, 5:07 pm)

Re: [PATCH 09/10] Change table chaining layout, Jeff Garzik, (Mon Oct 22, 5:11 pm)

powerpc: Fix fallout from sg_page() changes, Olof Johansson, (Mon Oct 22, 9:09 pm)

IB/ehca: Fix sg_page() fallout, Olof Johansson, (Mon Oct 22, 9:31 pm)

Re: IB/ehca: Fix sg_page() fallout, Jens Axboe, (Mon Oct 22, 10:05 pm)

Re: [PATCH 02/10] [SG] Update block layer to use sg helpers, Heiko Carstens, (Mon Oct 22, 10:13 pm)

Re: [PATCH 02/10] [SG] Update block layer to use sg helpers, Jens Axboe, (Mon Oct 22, 10:16 pm)

[PATCH] fix ll_rw_blk.c build on s390, Heiko Carstens, (Mon Oct 22, 10:42 pm)

[PATCH] net: fix xfrm build - missing scatterlist.h include, Heiko Carstens, (Mon Oct 22, 10:44 pm)

Re: IB/ehca: Fix sg_page() fallout, Olof Johansson, (Mon Oct 22, 10:54 pm)

Re: [PATCH 04/10] [SG] Update drivers to use sg helpers, Heiko Carstens, (Mon Oct 22, 11:28 pm)

Re: IB/ehca: Fix sg_page() fallout, Jens Axboe, (Tue Oct 23, 12:12 am)

Re: powerpc: Fix fallout from sg_page() changes, Jens Axboe, (Tue Oct 23, 12:13 am)

Re: [PATCH 04/10] [SG] Update drivers to use sg helpers, Jens Axboe, (Tue Oct 23, 12:14 am)

Re: [PATCH 04/10] [SG] Update drivers to use sg helpers, Heiko Carstens, (Tue Oct 23, 12:16 am)

Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Tue Oct 23, 12:18 am)

Re: [PATCH 08/10] [SG] Update arch/ to use sg helpers, Jens Axboe, (Tue Oct 23, 12:26 am)

Re: [PATCH] net: fix xfrm build - missing scatterlist.h in ..., Jens Axboe, (Tue Oct 23, 12:28 am)

Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 2:29 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 2:41 am)

Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 2:50 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 2:55 am)

Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 3:23 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 3:29 am)

Re: [PATCH 09/10] Change table chaining layout, Ingo Molnar, (Tue Oct 23, 3:33 am)

Re: [PATCH 06/10] [SG] Update net/ to use sg helpers, Christian Borntraeger, (Tue Oct 23, 3:44 am)

Re: [PATCH 06/10] [SG] Update net/ to use sg helpers, Jens Axboe, (Tue Oct 23, 3:45 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 3:56 am)

Re: [PATCH 09/10] Change table chaining layout, Ingo Molnar, (Tue Oct 23, 4:27 am)

Re: [PATCH 02/10] [SG] Update block layer to use sg helpers, John Stoffel, (Tue Oct 23, 7:32 am)

[PATCH][SG] fix typo in ps3rom.c, Arnd Bergmann, (Tue Oct 23, 7:48 am)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Tue Oct 23, 8:22 am)

Re: [PATCH 09/10] Change table chaining layout, Boaz Harrosh, (Tue Oct 23, 10:08 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 11:33 am)

Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Tue Oct 23, 12:23 pm)

Re: [PATCH 09/10] Change table chaining layout, Andi Kleen, (Tue Oct 23, 12:56 pm)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 1:20 pm)

Re: [PATCH 09/10] Change table chaining layout, Andi Kleen, (Tue Oct 23, 1:57 pm)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 2:44 pm)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 2:46 pm)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Tue Oct 23, 11:56 pm)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 1:05 am)

Re: [PATCH 09/10] Change table chaining layout, Geert Uytterhoeven, (Wed Oct 24, 2:03 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 2:12 am)

Re: [PATCH 09/10] Change table chaining layout, Olivier Galibert, (Wed Oct 24, 6:35 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Wed Oct 24, 6:38 am)

Re: [PATCH 09/10] Change table chaining layout, Olivier Galibert, (Wed Oct 24, 6:45 am)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Wed Oct 24, 8:16 am)

Re: [PATCH 09/10] Change table chaining layout, Rusty Russell, (Thu Oct 25, 1:40 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Thu Oct 25, 2:11 am)

Re: [PATCH 09/10] Change table chaining layout, Rusty Russell, (Thu Oct 25, 4:54 am)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Thu Oct 25, 8:40 am)

Re: [PATCH 09/10] Change table chaining layout, Benny Halevy, (Thu Oct 25, 9:03 am)

Re: [PATCH 09/10] Change table chaining layout, Rusty Russell, (Thu Oct 25, 5:03 pm)

Re: [PATCH 09/10] Change table chaining layout, Paul Mackerras, (Thu Oct 25, 10:01 pm)

Re: [PATCH 09/10] Change table chaining layout, Linus Torvalds, (Fri Oct 26, 7:52 am)

Re: [PATCH 09/10] Change table chaining layout, Jens Axboe, (Fri Oct 26, 10:28 am)

[RFC PATCH 1/2] sg_ring instead of scatterlist chaining, Rusty Russell, (Sun Nov 4, 11:11 pm)

[RFC PATCH 2/2] sg_ring instead of scatterlist chaining in ..., Rusty Russell, (Sun Nov 4, 11:15 pm)

Re: [RFC PATCH 1/2] sg_ring instead of scatterlist chaining, Randy Dunlap, (Mon Nov 5, 9:40 am)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client