Re: [RFC 9/13] Char: nozomi, lock cleanup

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Frank Seidel

Subject: Re: [RFC 9/13] Char: nozomi, lock cleanup

Date: Saturday, November 10, 2007 - 8:42 am

On Samstag 10 November 2007 00:48:52, you (Jiri Slaby) wrote:
quoted text> nozomi, lock cleanup
> 
> - semaphore is deprecated, use mutex instead
> - don't return -ERESTARTSYS when signal might not be pending since it's not
>   permitted (unknown retval mioght reach userspace)
> - don't lock interruptible in close or the card might not be stopped on last
>   close

Good catches. But i had to change it a bit, especially the mutex_trylock.
From mutex.c: "..it is negated to the down_trylock() return values!
Be careful about this when converting semaphores to mutexes." ;-)
Now it works again (doesn't deadlock my card anymore).

Thanks,
Frank
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC 1/13] Char: nozomi, remove unneded stuff, Jiri Slaby, (Fri Nov 9, 4:43 pm)

[RFC 2/13] Char: nozomi, expand some functions, Jiri Slaby, (Fri Nov 9, 4:44 pm)

[RFC 3/13] Char: nozomi, fix fail paths, Jiri Slaby, (Fri Nov 9, 4:44 pm)

[RFC 4/13] Char: nozomi, tty index cleanup, Jiri Slaby, (Fri Nov 9, 4:45 pm)

[RFC 5/13] Char: nozomi, ioctls cleanup, Jiri Slaby, (Fri Nov 9, 4:46 pm)

[RFC 6/13] Char: nozomi, reorder and cleanup probe, remove, Jiri Slaby, (Fri Nov 9, 4:46 pm)

[RFC 7/13] Char: nozomi, remove struct irq, Jiri Slaby, (Fri Nov 9, 4:47 pm)

[RFC 8/13] Char: nozomi, tty cleanup, Jiri Slaby, (Fri Nov 9, 4:48 pm)

[RFC 9/13] Char: nozomi, lock cleanup, Jiri Slaby, (Fri Nov 9, 4:48 pm)

[RFC! 10/13] Char: nozomi, fix tty_flip_buffer_push, Jiri Slaby, (Fri Nov 9, 4:49 pm)

[RFC 11/13] Char: nozomi, remove unused includes, Jiri Slaby, (Fri Nov 9, 4:50 pm)

[RFC 12/13] Char: nozomi, remove void acc char2 char3 more ..., Jiri Slaby, (Fri Nov 9, 4:50 pm)

[RFC 13/13] Char: nozomi, cleanup read and write, Jiri Slaby, (Fri Nov 9, 4:51 pm)

Re: [RFC 1/13] Char: nozomi, remove unneded stuff, Frank Seidel, (Sat Nov 10, 8:41 am)

Re: [RFC 2/13] Char: nozomi, expand some functions, Frank Seidel, (Sat Nov 10, 8:41 am)

Re: [RFC 3/13] Char: nozomi, fix fail paths, Frank Seidel, (Sat Nov 10, 8:41 am)

Re: [RFC 4/13] Char: nozomi, tty index cleanup, Frank Seidel, (Sat Nov 10, 8:41 am)

Re: [RFC 5/13] Char: nozomi, ioctls cleanup, Frank Seidel, (Sat Nov 10, 8:41 am)

Re: [RFC 6/13] Char: nozomi, reorder and cleanup probe, remove, Frank Seidel, (Sat Nov 10, 8:42 am)

Re: [RFC 7/13] Char: nozomi, remove struct irq, Frank Seidel, (Sat Nov 10, 8:42 am)

Re: [RFC 8/13] Char: nozomi, tty cleanup, Frank Seidel, (Sat Nov 10, 8:42 am)

Re: [RFC 9/13] Char: nozomi, lock cleanup, Frank Seidel, (Sat Nov 10, 8:42 am)

Re: [RFC! 10/13] Char: nozomi, fix tty_flip_buffer_push, Frank Seidel, (Sat Nov 10, 8:43 am)

Re: [RFC 11/13] Char: nozomi, remove unused includes, Frank Seidel, (Sat Nov 10, 8:43 am)

Re: [RFC 12/13] Char: nozomi, remove void acc char2 char3 ..., Frank Seidel, (Sat Nov 10, 8:43 am)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Frank Seidel, (Sat Nov 10, 8:43 am)

Re: [RFC 4/13] Char: nozomi, tty index cleanup, Jiri Slaby, (Sat Nov 10, 8:50 am)

Re: [RFC 1/13] Char: nozomi, remove unneded stuff, Jiri Slaby, (Sat Nov 10, 8:55 am)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Adrian Bunk, (Sat Nov 10, 9:15 am)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Jiri Slaby, (Sat Nov 10, 3:04 pm)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Frank Seidel, (Sat Nov 10, 7:37 pm)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Frank Seidel, (Sun Nov 11, 9:02 am)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Adrian Bunk, (Mon Nov 12, 12:54 am)

Re: [RFC 13/13] Char: nozomi, cleanup read and write, Frank Seidel, (Mon Nov 12, 2:43 am)

Re: [RFC 7/13] Char: nozomi, remove struct irq, Frank Seidel, (Mon Nov 12, 8:11 am)

Re: [RFC 8/13] Char: nozomi, tty cleanup, Frank Seidel, (Mon Nov 12, 11:43 am)