[PATCH 02/16] Unionfs: minor cleanup in writepage

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Erez Zadok
Date: Monday, November 26, 2007 - 9:43 am

From: Hugh Dickins <hugh@veritas.com>

Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
---
 fs/unionfs/mmap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index 4918f77..1e10280 100644
--- a/fs/unionfs/mmap.c
+++ b/fs/unionfs/mmap.c
@@ -56,6 +56,7 @@ static int unionfs_writepage(struct page *page, struct writeback_control *wbc)
 	copy_highpage(lower_page, page);
 	flush_dcache_page(lower_page);
 	SetPageUptodate(lower_page);
+	set_page_dirty(lower_page);
 
 	/*
 	 * Call lower writepage (expects locked page).  However, if we are
@@ -66,12 +67,11 @@ static int unionfs_writepage(struct page *page, struct writeback_control *wbc)
 	 * success.
 	 */
 	if (wbc->for_reclaim) {
-		set_page_dirty(lower_page);
 		unlock_page(lower_page);
 		goto out_release;
 	}
+
 	BUG_ON(!lower_mapping->a_ops->writepage);
-	set_page_dirty(lower_page);
 	clear_page_dirty_for_io(lower_page); /* emulate VFS behavior */
 	err = lower_mapping->a_ops->writepage(lower_page, wbc);
 	if (err < 0)
-- 
1.5.2.2

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PULL -mm] 00/16 Unionfs updates/fixes/cleanups, Erez Zadok, (Mon Nov 26, 9:43 am)
[PATCH 02/16] Unionfs: minor cleanup in writepage, Erez Zadok, (Mon Nov 26, 9:43 am)
[PATCH 11/16] Unionfs: update times in setattr, Erez Zadok, (Mon Nov 26, 9:44 am)
[PATCH 12/16] Unionfs: reintroduce a bmap method, Erez Zadok, (Mon Nov 26, 9:44 am)
[PATCH 13/16] Unionfs: support splice(2), Erez Zadok, (Mon Nov 26, 9:44 am)