namespace support requires network modules to say "GPL"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Mark Lord
Date: Saturday, December 1, 2007 - 6:10 am

> Now that we have network namespace support merged it is time to
...

Now that the namespace updates are part of 2.6.24,
there is a major inconsistency in network EXPORT_SYMBOLs.

It used to be that an external network module could get away without
having to add a MODULE_LICENSE("GPL*") line to the source.

In support of that, common networking functions (still) use EXPORT_SYMBOL()
rather than the more restrictive EXPORT_SYMBOL_GPL().

Eg.  register_netdev(), sk_alloc(), __dev_get_by_name().

But now, none of those three are actually usable by default,
because they all require "init_net", which is EXPORT_SYMBOL_GPL().

So.. It appears that one of three things should really happen next:

1) Change the other exports to also be EXPORT_SYMBOL_GPL.

2) Have register_netdev, sk_alloc, and __dev_get_by_name default
to using init_net when NULL is specified in the namespace field.

or 

3) Change init_net to be EXPORT_SYMBOL_GPL.

Right now, things are just a bit inconsistent, and it's not clear
whether the namespace changes intended this consequence or not.

Cheers

(as for me, I think all kernel modules are GPL, whether they have
 the MODULE_LICENSE line or not, so flames to /dev/null on that).
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/10] sysfs network namespace support, Eric W. Biederman, (Sat Dec 1, 2:06 am)
[PATCH 01/10] sysfs: Make sysfs_mount static again., Eric W. Biederman, (Sat Dec 1, 2:12 am)
[PATCH 02/10] sysfs: Support for preventing unmounts., Eric W. Biederman, (Sat Dec 1, 2:13 am)
[PATCH 03/10] sysfs: sysfs_get_dentry add a sb parameter, Eric W. Biederman, (Sat Dec 1, 2:16 am)
[PATCH 04/10] sysfs: Implement __sysfs_get_dentry, Eric W. Biederman, (Sat Dec 1, 2:18 am)
namespace support requires network modules to say "GPL", Mark Lord, (Sat Dec 1, 6:10 am)
Re: [PATCH 0/10] sysfs network namespace support, Greg KH, (Thu Dec 20, 8:07 pm)
Re: [PATCH 0/10] sysfs network namespace support, Eric W. Biederman, (Fri Dec 21, 6:04 am)