Home » Mailing list archives » linux-kernel » 2007 » December » 4

[patch] ext2: xip check fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin
Subject: [patch] ext2: xip check fix
Date: Tuesday, December 4, 2007 - 4:23 am

Am I missing something here? I wonder how s390 works without this change?

--
ext2 should not worry about checking sb->s_blocksize for XIP before the
sb's blocksize actually gets set.

Signed-off-by: Nick Piggin <npiggin@suse.de>
---
Index: linux-2.6/fs/ext2/super.c
===================================================================
--- linux-2.6.orig/fs/ext2/super.c
+++ linux-2.6/fs/ext2/super.c
@@ -844,8 +844,7 @@ static int ext2_fill_super(struct super_
 
 	blocksize = BLOCK_SIZE << le32_to_cpu(sbi->s_es->s_log_block_size);
 
-	if ((ext2_use_xip(sb)) && ((blocksize != PAGE_SIZE) ||
-				  (sb->s_blocksize != blocksize))) {
+	if (ext2_use_xip(sb) && blocksize != PAGE_SIZE) {
 		if (!silent)
 			printk("XIP: Unsupported blocksize\n");
 		goto failed_mount;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] rewrite rd, Nick Piggin, (Mon Dec 3, 9:26 pm)
Re: [patch] rewrite rd, Andrew Morton, (Mon Dec 3, 11:29 pm)
Re: [patch] rewrite rd, Nick Piggin, (Tue Dec 4, 12:01 am)
Re: [patch] rewrite rd, Nick Piggin, (Tue Dec 4, 12:08 am)
Re: [patch] rewrite rd, Rob Landley, (Tue Dec 4, 12:55 am)
Re: [patch] rewrite rd, Nick Piggin, (Tue Dec 4, 2:29 am)
Re: [patch] rewrite rd, Christian Borntraeger, (Tue Dec 4, 2:54 am)
Re: [patch] rewrite rd, Nick Piggin, (Tue Dec 4, 3:10 am)
[patch] rd: support XIP, Nick Piggin, (Tue Dec 4, 4:21 am)
[patch] ext2: xip check fix, Nick Piggin, (Tue Dec 4, 4:23 am)
Re: [patch] rd: support XIP, Andrew Morton, (Tue Dec 4, 4:26 am)
Re: [patch] rd: support XIP, Nick Piggin, (Tue Dec 4, 4:35 am)
Re: [patch] rd: support XIP, Duane Griffin, (Tue Dec 4, 5:06 am)
[patch] mm: fix XIP file writes, Nick Piggin, (Tue Dec 4, 6:00 am)
[patch] rd: support XIP (updated), Nick Piggin, (Tue Dec 4, 6:03 am)
Re: [patch] rewrite rd, Rob Landley, (Tue Dec 4, 12:53 pm)
Re: [patch] ext2: xip check fix, Carsten Otte, (Wed Dec 5, 8:43 am)
Re: [patch] ext2: xip check fix, Nick Piggin, (Wed Dec 5, 4:33 pm)
Re: [patch] ext2: xip check fix, Carsten Otte, (Thu Dec 6, 1:43 am)
Re: [patch] ext2: xip check fix, Nick Piggin, (Thu Dec 6, 1:52 am)
Re: [patch] ext2: xip check fix, Carsten Otte, (Thu Dec 6, 2:59 am)
Re: [patch] ext2: xip check fix, Nick Piggin, (Thu Dec 6, 3:18 am)
Re: [patch] ext2: xip check fix, Carsten Otte, (Thu Dec 6, 3:24 am)
Re: [patch] ext2: xip check fix, Rob Landley, (Thu Dec 6, 11:11 am)
Re: [patch] ext2: xip check fix, Jared Hulbert, (Thu Dec 6, 8:22 pm)
Re: [patch] ext2: xip check fix, Rob Landley, (Thu Dec 6, 9:17 pm)
Re: [patch] ext2: xip check fix, Nick Piggin, (Thu Dec 6, 9:23 pm)
Re: [patch] ext2: xip check fix, Jared Hulbert, (Thu Dec 6, 9:40 pm)
Re: [patch] ext2: xip check fix, Carsten Otte, (Fri Dec 7, 1:59 am)
Re: [patch] ext2: xip check fix, Jared Hulbert, (Fri Dec 7, 2:52 am)
Re: [patch] mm: fix XIP file writes, Christian Borntraeger, (Mon Dec 10, 7:38 am)
Re: [patch] mm: fix XIP file writes, Nick Piggin, (Tue Dec 11, 9:03 pm)
Re: [patch] rewrite rd, Matthew Wilcox, (Mon Jan 14, 9:47 am)
Re: [patch] rewrite rd, Jens Axboe, (Mon Jan 14, 10:21 am)