[PATCH] mmc: remove unused 'mode' from the mmc_host structure

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Nicolas Pitre
Date: Thursday, December 6, 2007 - 9:12 pm

This field and corresponding defines are simply never used anywhere
in the code.  But its mere presence is enough to confuse some host 
driver authors who attempt to rely on it.  Let's eliminate the 
possibility for confusion and remove it entirely.

Signed-off-by: Nicolas Pitre <nico@cam.org>
---

yes, it's the second host driver I'm reviewing with this issue...

diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 125eee1..7ab962f 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -118,10 +118,6 @@ struct mmc_host {
 	unsigned int		removed:1;	/* host is being removed */
 #endif
 
-	unsigned int		mode;		/* current card mode of host */
-#define MMC_MODE_MMC		0
-#define MMC_MODE_SD		1
-
 	struct mmc_card		*card;		/* device attached to this host */
 
 	wait_queue_head_t	wq;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] mmc: remove unused 'mode' from the mmc_host structure, Nicolas Pitre, (Thu Dec 6, 9:12 pm)