Home » Mailing list archives » linux-kernel » 2007 » February » 1

[PATCH 4/10] POWERPC-Powermac: local_irq_disable() is redundant after local_irq_save()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jiri Kosina
Subject: [PATCH 4/10] POWERPC-Powermac: local_irq_disable() is redundant after local_irq_save()
Date: Thursday, February 1, 2007 - 8:36 am

From: Jiri Kosina <jkosina@suse.cz>

POWERPC-Powermac: local_irq_disable() is redundant after local_irq_save()

arch/powerpc/platforms/powermac/smp.c::smp_core99_kick_cpu() contains
local_irq_disable() call after local_irq_save(). This looks
redundant.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

---

 arch/powerpc/platforms/powermac/smp.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c
index eeb2ae5..d73fb73 100644
--- a/arch/powerpc/platforms/powermac/smp.c
+++ b/arch/powerpc/platforms/powermac/smp.c
@@ -795,7 +795,6 @@ static void __devinit smp_core99_kick_cpu(int nr)
 		ppc_md.progress("smp_core99_kick_cpu", 0x346);
 
 	local_irq_save(flags);
-	local_irq_disable();
 
 	/* Save reset vector */
 	save_vector = *vector;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/10] fix usages of local_irq_save() and local_irq_ ..., Jiri Kosina, (Thu Feb 1, 8:35 am)
[PATCH 1/10] CRIS: local_irq_disable() is redundant after ..., Jiri Kosina, (Thu Feb 1, 8:35 am)
[PATCH 2/10] X86_64: local_irq_disable() is redundant afte ..., Jiri Kosina, (Thu Feb 1, 8:35 am)
[PATCH 3/10] POWERPC-86xx: local_irq_disable() is redundan ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 4/10] POWERPC-Powermac: local_irq_disable() is redu ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 5/10] SCSI-BusLogic: local_irq_disable() is redunda ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 6/10] CHAR-Amiserial: turn local_save_flags() + loc ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 7/10] CHAR-Amiserial: turn local_save_flags() + loc ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 8/10] NET-3c59x: turn local_save_flags() + local_ir ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 9/10] CRIS: turn local_save_flags() + local_irq_dis ..., Jiri Kosina, (Thu Feb 1, 8:36 am)
[PATCH 10/10] CRIS: turn local_save_flags() + local_irq_di ..., Jiri Kosina, (Thu Feb 1, 8:36 am)