[patch 10/21] ide: fix drive side 80c cable check

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg KH
Date: Tuesday, February 20, 2007 - 6:37 pm

-stable review patch.  If anyone has any objections, please let us know.

------------------

eighty_ninty_three() had word 93 validitity check but not the 80c bit
test itself (bit 12).  This increases the chance of incorrect wire
detection especially because host side cable detection is often
unreliable and we sometimes soley depend on drive side cable
detection.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/ide/ide-iops.c |    2 ++
 1 file changed, 2 insertions(+)

--- linux-2.6.19.4.orig/drivers/ide/ide-iops.c
+++ linux-2.6.19.4/drivers/ide/ide-iops.c
@@ -607,6 +607,8 @@ u8 eighty_ninty_three (ide_drive_t *driv
 	if(!(drive->id->hw_config & 0x4000))
 		return 0;
 #endif /* CONFIG_IDEDMA_IVB */
+	if (!(drive->id->hw_config & 0x2000))
+		return 0;
 	return 1;
 }
 

--
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/21] 2.6.19-stable review, Greg KH, (Tue Feb 20, 6:36 pm)
[patch 01/21] V4L: cx88: Fix lockup on suspend, Greg KH, (Tue Feb 20, 6:36 pm)
[patch 03/21] V4L: fix ks0127 status flags, Greg KH, (Tue Feb 20, 6:36 pm)
[patch 10/21] ide: fix drive side 80c cable check, Greg KH, (Tue Feb 20, 6:37 pm)
[patch 12/21] bcm43xx: Fix for oops on resume, Greg KH, (Tue Feb 20, 6:37 pm)
Re: [patch 00/21] 2.6.19-stable review, Stefan Richter, (Wed Feb 21, 6:36 am)
Re: [patch 00/21] 2.6.19-stable review, Stefan Richter, (Wed Feb 21, 6:37 am)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 9:38 am)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 9:50 am)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 12:31 pm)
Re: [patch 00/21] 2.6.19-stable review, Andrew Morton, (Wed Feb 21, 12:47 pm)
Re: [patch 00/21] 2.6.19-stable review, Linus Torvalds, (Wed Feb 21, 1:09 pm)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 21, 1:13 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 1:21 pm)
Re: [patch 00/21] 2.6.19-stable review, Greg KH, (Wed Feb 21, 1:39 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 1:44 pm)
Re: [patch 00/21] 2.6.19-stable review, Andi Kleen, (Wed Feb 21, 3:19 pm)
Re: [patch 00/21] 2.6.19-stable review, Andi Kleen, (Wed Feb 21, 3:20 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 3:33 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 3:39 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 3:43 pm)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 21, 3:45 pm)
Re: [patch 01/21] V4L: cx88: Fix lockup on suspend, Chuck Ebbert, (Wed Feb 21, 6:00 pm)
Re: [patch 01/21] V4L: cx88: Fix lockup on suspend, Michael Krufky, (Wed Feb 21, 6:14 pm)
Re: [patch 00/21] 2.6.19-stable review, Andi Kleen, (Wed Feb 21, 6:19 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Thu Feb 22, 9:09 am)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Tue Feb 27, 11:37 pm)
Re: [patch 00/21] 2.6.19-stable review, Zwane Mwaikambo, (Wed Feb 28, 1:51 am)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 28, 5:28 am)
Re: [stable] [patch 00/21] 2.6.19-stable review, Greg KH, (Wed Feb 28, 12:52 pm)
Re: [stable] [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 28, 4:25 pm)
Re: [patch 00/21] 2.6.19-stable review, Adrian Bunk, (Thu Mar 8, 10:35 pm)