[patch 11/21] pata_amd: fix an obvious bug in cable detection

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg KH
Date: Tuesday, February 20, 2007 - 6:37 pm

-stable review patch.  If anyone has any objections, please let us know.

------------------

80c test mask is at bits 18 and 19 of EIDE Controller Configuration
not 22 and 23.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>

---
 drivers/ata/pata_amd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.19.4.orig/drivers/ata/pata_amd.c
+++ linux-2.6.19.4/drivers/ata/pata_amd.c
@@ -128,7 +128,7 @@ static void timing_setup(struct ata_port
 
 static int amd_pre_reset(struct ata_port *ap)
 {
-	static const u32 bitmask[2] = {0x03, 0xC0};
+	static const u32 bitmask[2] = {0x03, 0x0C};
 	static const struct pci_bits amd_enable_bits[] = {
 		{ 0x40, 1, 0x02, 0x02 },
 		{ 0x40, 1, 0x01, 0x01 }
@@ -247,7 +247,7 @@ static void amd133_set_dmamode(struct at
  */
 
 static int nv_pre_reset(struct ata_port *ap) {
-	static const u8 bitmask[2] = {0x03, 0xC0};
+	static const u8 bitmask[2] = {0x03, 0x0C};
 	static const struct pci_bits nv_enable_bits[] = {
 		{ 0x50, 1, 0x02, 0x02 },
 		{ 0x50, 1, 0x01, 0x01 }

--
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/21] 2.6.19-stable review, Greg KH, (Tue Feb 20, 6:36 pm)
[patch 01/21] V4L: cx88: Fix lockup on suspend, Greg KH, (Tue Feb 20, 6:36 pm)
[patch 03/21] V4L: fix ks0127 status flags, Greg KH, (Tue Feb 20, 6:36 pm)
[patch 11/21] pata_amd: fix an obvious bug in cable detection, Greg KH, (Tue Feb 20, 6:37 pm)
[patch 12/21] bcm43xx: Fix for oops on resume, Greg KH, (Tue Feb 20, 6:37 pm)
Re: [patch 00/21] 2.6.19-stable review, Stefan Richter, (Wed Feb 21, 6:36 am)
Re: [patch 00/21] 2.6.19-stable review, Stefan Richter, (Wed Feb 21, 6:37 am)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 9:38 am)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 9:50 am)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 12:31 pm)
Re: [patch 00/21] 2.6.19-stable review, Andrew Morton, (Wed Feb 21, 12:47 pm)
Re: [patch 00/21] 2.6.19-stable review, Linus Torvalds, (Wed Feb 21, 1:09 pm)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 21, 1:13 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 1:21 pm)
Re: [patch 00/21] 2.6.19-stable review, Greg KH, (Wed Feb 21, 1:39 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 1:44 pm)
Re: [patch 00/21] 2.6.19-stable review, Andi Kleen, (Wed Feb 21, 3:19 pm)
Re: [patch 00/21] 2.6.19-stable review, Andi Kleen, (Wed Feb 21, 3:20 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 3:33 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 3:39 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Wed Feb 21, 3:43 pm)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 21, 3:45 pm)
Re: [patch 01/21] V4L: cx88: Fix lockup on suspend, Chuck Ebbert, (Wed Feb 21, 6:00 pm)
Re: [patch 01/21] V4L: cx88: Fix lockup on suspend, Michael Krufky, (Wed Feb 21, 6:14 pm)
Re: [patch 00/21] 2.6.19-stable review, Andi Kleen, (Wed Feb 21, 6:19 pm)
Re: [patch 00/21] 2.6.19-stable review, Chuck Ebbert, (Thu Feb 22, 9:09 am)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Tue Feb 27, 11:37 pm)
Re: [patch 00/21] 2.6.19-stable review, Zwane Mwaikambo, (Wed Feb 28, 1:51 am)
Re: [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 28, 5:28 am)
Re: [stable] [patch 00/21] 2.6.19-stable review, Greg KH, (Wed Feb 28, 12:52 pm)
Re: [stable] [patch 00/21] 2.6.19-stable review, Eric W. Biederman, (Wed Feb 28, 4:25 pm)
Re: [patch 00/21] 2.6.19-stable review, Adrian Bunk, (Thu Mar 8, 10:35 pm)