[patch 03/20] tcp conntrack: accept SYN|URG as valid

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg KH
Date: Friday, March 9, 2007 - 11:16 pm

-stable review patch.  If anyone has any objections, please let us know.

------------------
From: Patrick McHardy <kaber@trash.net>

[NETFILTER]: tcp conntrack: accept SYN|URG as valid

Some stacks apparently send packets with SYN|URG set. Linux accepts
these packets, so TCP conntrack should to.

Pointed out by Martijn Posthuma <posthuma@sangine.com>.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
 net/ipv4/netfilter/ip_conntrack_proto_tcp.c |    4 +++-
 net/netfilter/nf_conntrack_proto_tcp.c      |    4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

--- a/net/ipv4/netfilter/ip_conntrack_proto_tcp.c
+++ b/net/ipv4/netfilter/ip_conntrack_proto_tcp.c
@@ -821,8 +821,10 @@ void ip_conntrack_tcp_update(struct sk_b
 static const u8 tcp_valid_flags[(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG) + 1] =
 {
 	[TH_SYN]			= 1,
-	[TH_SYN|TH_ACK]			= 1,
 	[TH_SYN|TH_PUSH]		= 1,
+	[TH_SYN|TH_URG]			= 1,
+	[TH_SYN|TH_PUSH|TH_URG]		= 1,
+	[TH_SYN|TH_ACK]			= 1,
 	[TH_SYN|TH_ACK|TH_PUSH]		= 1,
 	[TH_RST]			= 1,
 	[TH_RST|TH_ACK]			= 1,
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b/net/netfilter/nf_conntrack_proto_tcp.c
@@ -778,8 +778,10 @@ EXPORT_SYMBOL_GPL(nf_conntrack_tcp_updat
 static u8 tcp_valid_flags[(TH_FIN|TH_SYN|TH_RST|TH_PUSH|TH_ACK|TH_URG) + 1] =
 {
 	[TH_SYN]			= 1,
-	[TH_SYN|TH_ACK]			= 1,
 	[TH_SYN|TH_PUSH]		= 1,
+	[TH_SYN|TH_URG]			= 1,
+	[TH_SYN|TH_PUSH|TH_URG]		= 1,
+	[TH_SYN|TH_ACK]			= 1,
 	[TH_SYN|TH_ACK|TH_PUSH]		= 1,
 	[TH_RST]			= 1,
 	[TH_RST|TH_ACK]			= 1,

-- 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/20] 2.6.20-stable review, Greg KH, (Fri Mar 9, 11:16 pm)
[patch 03/20] tcp conntrack: accept SYN|URG as valid, Greg KH, (Fri Mar 9, 11:16 pm)
[patch 04/20] nfnetlink_log: fix reference leak, Greg KH, (Fri Mar 9, 11:17 pm)
[patch 05/20] nfnetlink_log: fix use after free, Greg KH, (Fri Mar 9, 11:17 pm)
[patch 15/20] Fix compat_getsockopt, Greg KH, (Fri Mar 9, 11:18 pm)
[patch 17/20] Fix callback bug in connector, Greg KH, (Fri Mar 9, 11:18 pm)
[patch 19/20] Fix timewait jiffies, Greg KH, (Fri Mar 9, 11:18 pm)
Re: [patch 00/20] 2.6.20-stable review, Greg KH, (Fri Mar 9, 11:23 pm)
Re: [patch 00/20] 2.6.20-stable review, Chuck Ebbert, (Sat Mar 10, 2:43 pm)
Re: [patch 00/20] 2.6.20-stable review, Greg KH, (Sat Mar 10, 2:49 pm)