Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ops callsites to make them patchable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Tuesday, March 20, 2007 - 11:49 am

On Tue, 20 Mar 2007, Andi Kleen wrote:

the thing is, I'd rather see a long backtrace that is hard to decipher but 
that *never* *ever* causes any additional problems, over a pretty one.

Because that's really the issue: do you want a "pretty" backtrace, or do 
you want one that is rock solid but has some crud in it.

I'll take the rock solid one any day. Especially as even the pretty one 
won't fix the most common problem, which is "I don't see the caller" (due 
to inlining or tail-calls).

In contrast, the ugly backtrace will have some "garbage entries" from 
previous frames that didn't get overwritten, but there have actually been 
(admittedly rare) cases where those garbage entries have given hints about 
what happened just before.

			Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 13/26] Xen-paravirt_ops: Consistently wrap paravirt ..., Jeremy Fitzhardinge, (Thu Mar 1, 4:24 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Fri Mar 16, 10:36 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Fri Mar 16, 12:16 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Fri Mar 16, 1:38 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Fri Mar 16, 5:40 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Sun Mar 18, 12:59 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Sun Mar 18, 8:58 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Sun Mar 18, 10:29 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Sun Mar 18, 4:46 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Mon Mar 19, 10:58 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Eric W. Biederman, (Mon Mar 19, 11:25 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Mon Mar 19, 12:10 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Mon Mar 19, 12:33 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Mon Mar 19, 1:06 pm)
[PATCH] x86_64 : Suppress __jiffies, Eric Dumazet, (Mon Mar 19, 2:55 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Mon Mar 19, 6:45 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Eric W. Biederman, (Mon Mar 19, 9:19 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Mon Mar 19, 10:54 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Eric W. Biederman, (Tue Mar 20, 8:58 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Eric W. Biederman, (Tue Mar 20, 9:25 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Tue Mar 20, 9:26 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Tue Mar 20, 9:31 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Linus Torvalds, (Tue Mar 20, 11:49 am)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Tue Mar 20, 4:33 pm)
Re: [patch 13/26] Xen-paravirt_ops: Consistently wrap para ..., Jeremy Fitzhardinge, (Tue Mar 20, 5:20 pm)