Re: [patch 2/5] signalfd v2 - signalfd core ...

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Denis Vlasenko
Date: Friday, March 30, 2007 - 4:24 pm

On Thursday 08 March 2007 18:28, Linus Torvalds wrote:

Wait a second here... O_NONBLOCK is not just unnecessary - it's buggy!

Try to do nonblocking read from stdin (fd #0) -
* setting O_NONBLOCK with fcntl will set it for all other processes
  which has the same stdin!
* trying to reset O_NONBLOCK after the read doesn't help (think kill -9)
* duping fd #0 doesn't help because O_NONBLOCK is not per-fd,
  it's shared just like filepos.

I really like that trick with recvmsg + MSG_DONTWAIT instead.
--
vda
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Wed Mar 7, 6:21 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., David M. Lloyd, (Thu Mar 8, 7:31 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Thu Mar 8, 8:45 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Linus Torvalds, (Thu Mar 8, 9:22 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Thu Mar 8, 9:29 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Michael K. Edwards, (Thu Mar 8, 9:40 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Linus Torvalds, (Thu Mar 8, 10:15 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Linus Torvalds, (Thu Mar 8, 10:28 am)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Thu Mar 8, 12:21 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Linus Torvalds, (Thu Mar 8, 12:27 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Thu Mar 8, 12:33 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Avi Kivity, (Thu Mar 8, 12:34 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Thu Mar 8, 12:40 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Marko Macek, (Thu Mar 8, 1:48 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Michael K. Edwards, (Thu Mar 8, 1:53 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Marko Macek, (Thu Mar 8, 2:03 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Jeremy Fitzhardinge, (Thu Mar 8, 4:57 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Linus Torvalds, (Thu Mar 8, 5:10 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Kent Overstreet, (Fri Mar 9, 1:22 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Davide Libenzi, (Fri Mar 9, 2:33 pm)
Re: [patch 2/5] signalfd v2 - signalfd core ..., Denis Vlasenko, (Fri Mar 30, 4:24 pm)