Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Andi Kleen

Subject: Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

Date: Thursday, March 8, 2007 - 10:14 am

On Wednesday 07 March 2007 21:45, Dave Jiang wrote:
quoted text> 
> The RESTORE_CONTEXT macro is missing the '\n' at the end. It was removed in the
> previous patch that touched system.h. It causes compile failure if any
> inline asm is added after the macro. Discovered this when playing with
> kgdb.

We went through this several times. kgdb has no business to poke 
into kernel private macros like this and it shouldn't do that. 
So fixing kgdb to not require touching the context switch is the right
change.

-Andi
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] x86_64 RESTORE_CONTEXT missing '\n', Dave Jiang, (Wed Mar 7, 1:45 pm)

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Andi Kleen, (Thu Mar 8, 10:14 am)

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Dave Jiang, (Thu Mar 8, 10:44 am)

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Andi Kleen, (Thu Mar 8, 11:37 am)

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Tom Rini, (Thu Mar 8, 11:49 am)

Permanent Kgdb integration into the kernel - lets get with it., Piet Delaney, (Thu Mar 8, 3:24 pm)

Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n', Andi Kleen, (Thu Mar 8, 3:36 pm)

Re: Permanent Kgdb integration into the kernel - lets get ..., Randy Dunlap, (Tue Apr 17, 11:30 am)

Re: Permanent Kgdb integration into the kernel - lets get ..., Sergei Shtylyov, (Tue Apr 17, 11:37 am)

Re: Permanent Kgdb integration into the kernel - lets get ..., Randy Dunlap, (Tue Apr 17, 11:42 am)

Re: Permanent Kgdb integration into the kernel - lets get ..., Andi Kleen, (Tue Apr 17, 11:45 am)

Re: Permanent Kgdb integration into the kernel - lets get ..., Sergei Shtylyov, (Tue Apr 17, 11:45 am)

Re: Permanent Kgdb integration into the kernel - lets get ..., Robin Holt, (Fri Apr 20, 9:20 am)

Re: Permanent Kgdb integration into the kernel - lets get ..., Piet Delaney, (Fri Apr 20, 3:51 pm)

Re: Permanent Kgdb integration into the kernel - lets get ..., Andrew Morton, (Fri Apr 20, 4:34 pm)