On Sun, 22 Apr 2007, Christoph Hellwig wrote:
quoted text > On Thu, Apr 19, 2007 at 12:55:29AM -0600, Eric W. Biederman wrote:
> > From: Eric W. Biederman <ebiederm@xmission.com> - unquoted
> >
> > kthread_run replaces the kernel_thread and daemonize calls
> > during thread startup.
> >
> > Calls to signal_pending were also removed as it is currently
> > impossible for the cpci_hotplug thread to receive signals.
>
> This drivers thread are a bit of a miss, although a lot better than
> most other pci hotplug drivers :)
Heh, I guess I'll take that as a compliment. :)
quoted text > Below is more complete conversion to the kthread infrastructure +
> wake_up_process to wake the thread. Note that we had to keep
> a thread_finished variable because the existing one had dual use.
[snip]
I'm out of the office today, but I'll give it a spin on a test setup
tomorrow.
Thanks,
Scott
--
Scott Murray
SOMA Networks, Inc.
Toronto, Ontario
e-mail:
scottm@somanetworks.com
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH] cpci_hotplug: Convert to use the kthread API , Scott Murray , (Mon Apr 23, 9:19 am)