Home » Mailing list archives » linux-kernel » 2007 » April » 28

[PATCH] [28/35] x86: Drop cc-options call for all options supported in gcc 3.2+

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: [PATCH] [28/35] x86: Drop cc-options call for all options supported in gcc 3.2+
Date: Saturday, April 28, 2007 - 10:52 am

The kernel only supports gcc 3.2+ now so it doesn't make sense
anymore to explicitely check for options this compiler version
already has.

This actually fixes a bug. The -mprefered-stack-boundary check
never worked because gcc rightly complains

  CC      arch/i386/kernel/asm-offsets.s
cc1: -mpreferred-stack-boundary=2 is not between 4 and 12

We just never saw the error because of cc-options.
I changed it to 4 to actually work.

Tested by compiling i386 and x86-64 defconfig with gcc 3.2.

Should speed up the build time a tiny bit and improve
stack usage on i386 slightly.

Signed-off-by: Andi Kleen <ak@suse.de>

---
 Makefile           |    2 +-
 arch/i386/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: linux/Makefile
===================================================================
--- linux.orig/Makefile
+++ linux/Makefile
@@ -491,7 +491,7 @@ endif
 include $(srctree)/arch/$(ARCH)/Makefile
 
 ifdef CONFIG_FRAME_POINTER
-CFLAGS		+= -fno-omit-frame-pointer $(call cc-option,-fno-optimize-sibling-calls,)
+CFLAGS		+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
 else
 CFLAGS		+= -fomit-frame-pointer
 endif
Index: linux/arch/i386/Makefile
===================================================================
--- linux.orig/arch/i386/Makefile
+++ linux/arch/i386/Makefile
@@ -34,7 +34,7 @@ CHECKFLAGS	+= -D__i386__
 CFLAGS += -pipe -msoft-float -mregparm=3 -freg-struct-return
 
 # prevent gcc from keeping the stack 16 byte aligned
-CFLAGS += $(call cc-option,-mpreferred-stack-boundary=2)
+CFLAGS += -mpreferred-stack-boundary=4
 
 # CPU-specific tuning. Anything which can be shared with UML should go here.
 include $(srctree)/arch/i386/Makefile.cpu
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/35] Some x86 2.6.22 candidate patches for review, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [1/35] i386: revert i386-fix-the-verify_quirk_inte ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [2/35] x86_64: revert x86_64-mm-add-genapic_force, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [3/35] x86: revert x86_64-mm-fix-the-irqbalance-qu ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [4/35] x86_64: optimize &amp; fix APIC mode setup, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [5/35] x86_64: always use physical delivery mode o ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [6/35] x86_64: remove clustered APIC mode, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [7/35] x86: default to physical mode on hotplug CP ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [8/35] x86_64: a memcpy that tries to reduce cache ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [9/35] i386: adjustments to page table dump during ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [10/35] x86: adjust inclusion of asm/fixmap.h, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [11/35] x86_64: adjust inclusion of asm/vsyscall32.h, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [12/35] x86: consolidate smp_send_stop(), Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [13/35] i386: No need to use -traditional for proc ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [14/35] i386: mtrr range check correction, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [15/35] i386: pit_latch_buggy has no effect, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [16/35] i386: Add an option for the VIA C7 which s ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [17/35] i386: probe_roms() cleanup, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [18/35] x86_64: a few missing entry.S annotations, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [19/35] i386: Add dwarf2 annotations to *_user and ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [20/35] x86: Fix i386 and x86_64 fault information ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [21/35] x86_64: Some cleanup in time.c, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [22/35] i386: i386 make NMI use PERFCTR1 for archi ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [23/35] x86_64: x86_64 make NMI use PERFCTR1 for a ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [24/35] i386: Add __init to probe_bigsmp, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [25/35] i386: Change sysenter_setup to __cpuinit &amp; ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [26/35] x86_64: Correct max number of CPUs in Kconfig, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [27/35] i386: Support Oprofile for AMD Family 10 CPUs, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [28/35] x86: Drop cc-options call for all options ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [29/35] i386: Update __copy_to_user_inatomic linu ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [30/35] i386: clean up mach_reboot_fixups, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [31/35] i386: Fix usage of -mtune when X86_GENERIC ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [32/35] x86_64: Remove unused set_seg_base, Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [33/35] x86_64: Remove duplicated code for reading ..., Andi Kleen, (Sat Apr 28, 10:52 am)
[PATCH] [34/35] x86_64: fix cpu MHz reporting on constant_ ..., Andi Kleen, (Sat Apr 28, 10:53 am)
[PATCH] [35/35] i386: Simplify smp_call_function*() by usi ..., Andi Kleen, (Sat Apr 28, 10:53 am)
Re: [PATCH] [16/35] i386: Add an option for the VIA C7 whi ..., Jeff Garzik, (Sat Apr 28, 11:08 am)
Re: [PATCH] [16/35] i386: Add an option for the VIA C7 whi ..., Dave Jones, (Sat Apr 28, 11:28 am)
Re: [patches] [PATCH] [8/35] x86_64: a memcpy that tries t ..., Jan Beulich, (Mon Apr 30, 12:26 am)
Re: [patches] [PATCH] [8/35] x86_64: a memcpy that tries t ..., Andi Kleen, (Mon Apr 30, 2:04 am)
Re: [patches] [PATCH] [8/35] x86_64: a memcpy that tries t ..., Bryan O'Sullivan, (Mon Apr 30, 9:14 am)