Re: 2.6.21-rc5-mm4 (SLUB)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Wednesday, April 4, 2007 - 10:03 am

On Wed, 4 Apr 2007, Badari Pulavarty wrote:


Ahh.... Seems that the first 4 bytes of the allocations is zapped after 
the object has been freed. Can you trap writes to the first four bytes of 
the object? This should give you the culprit.

The other thing is that the system is performing DMA allocations
for the file cache???? Then its running out of memory.

Argh.... We use  GFP DMA bitmask to check SLAB flags field:

Try this fix:



SLUB: Use correct flags to check for DMA cache

We use a GFP mask to check the SLAB flags if this is a DMA cache.

Fix this by using the correct SLAB mask and then use the SLUB_DMA
for the ORing of flags. If the system does not support DMA then
we will OR zero which will hopefully get the compiler to drop the
useless if statement as well.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.21-rc5-mm4/mm/slub.c
===================================================================
--- linux-2.6.21-rc5-mm4.orig/mm/slub.c	2007-04-04 09:59:05.000000000 -0700
+++ linux-2.6.21-rc5-mm4/mm/slub.c	2007-04-04 10:01:14.000000000 -0700
@@ -678,8 +678,8 @@ static struct page *allocate_slab(struct
 	if (s->order)
 		flags |= __GFP_COMP;
 
-	if (s->flags & SLUB_DMA)
-		flags |= GFP_DMA;
+	if (s->flags & SLAB_CACHE_DMA)
+		flags |= SLUB_DMA;
 
 	if (node == -1)
 		page = alloc_pages(flags, s->order);


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.21-rc5-mm4, Andrew Morton, (Mon Apr 2, 10:47 pm)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Tue Apr 3, 5:57 am)
Re: 2.6.21-rc5-mm4, Kok, Auke, (Tue Apr 3, 8:11 am)
Re: 2.6.21-rc5-mm4, Michal Piotrowski, (Tue Apr 3, 9:11 am)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Tue Apr 3, 9:30 am)
Re: 2.6.21-rc5-mm4, Kok, Auke, (Tue Apr 3, 10:19 am)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Tue Apr 3, 10:42 am)
Re: 2.6.21-rc5-mm4, Randy Dunlap, (Tue Apr 3, 12:48 pm)
Re: 2.6.21-rc5-mm4, Davide Libenzi, (Tue Apr 3, 12:51 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 1:31 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 1:40 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 2:55 pm)
Re: 2.6.21-rc5-mm4, Michal Piotrowski, (Tue Apr 3, 3:20 pm)
Re: 2.6.21-rc5-mm4, Con Kolivas, (Tue Apr 3, 3:31 pm)
Re: 2.6.21-rc5-mm4, J.A. , (Tue Apr 3, 3:40 pm)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Tue Apr 3, 3:51 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 3:53 pm)
Re: 2.6.21-rc5-mm4, J.A. , (Tue Apr 3, 3:58 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 3:59 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:19 pm)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Tue Apr 3, 4:22 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:27 pm)
Re: 2.6.21-rc5-mm4, Michal Piotrowski, (Tue Apr 3, 4:31 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:38 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:40 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:40 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:41 pm)
Re: 2.6.21-rc5-mm4, J.A. , (Tue Apr 3, 4:43 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:51 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:55 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 6:16 pm)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Tue Apr 3, 6:35 pm)
Re: 2.6.21-rc5-mm4, Randy Dunlap, (Tue Apr 3, 7:20 pm)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Tue Apr 3, 7:46 pm)
Re: 2.6.21-rc5-mm4, Randy Dunlap, (Tue Apr 3, 8:37 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Wed Apr 4, 7:53 am)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Wed Apr 4, 8:12 am)
[-mm patch] net/: possible cleanups, Adrian Bunk, (Wed Apr 4, 8:25 am)
[-mm patch] unexport pci_proc_attach_device, Adrian Bunk, (Wed Apr 4, 8:25 am)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Wed Apr 4, 8:27 am)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Wed Apr 4, 9:10 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 10:03 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Christoph Lameter, (Wed Apr 4, 10:13 am)
Re: 2.6.21-rc5-mm4, Eric W. Biederman, (Wed Apr 4, 10:22 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Badari Pulavarty, (Wed Apr 4, 10:33 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Christoph Lameter, (Wed Apr 4, 10:35 am)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Wed Apr 4, 10:55 am)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 11:02 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 11:04 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 11:09 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 11:22 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Badari Pulavarty, (Wed Apr 4, 1:53 pm)
Re: 2.6.21-rc5-mm4, Antonino A. Daplas, (Wed Apr 4, 2:56 pm)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Wed Apr 4, 3:10 pm)
Re: 2.6.21-rc5-mm4, Con Kolivas, (Wed Apr 4, 3:38 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 3:53 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 3:59 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 4:42 pm)
Re: 2.6.21-rc5-mm4, Antonino A. Daplas, (Wed Apr 4, 4:55 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 5:31 pm)
Re: 2.6.21-rc5-mm4, Antonino A. Daplas, (Wed Apr 4, 5:56 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 7:44 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 8:15 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 9:29 pm)
Re: 2.6.21-rc5-mm4, Sam Ravnborg, (Thu Apr 5, 4:14 am)
[-mm patch] pcm_native: lockdep warning when launching jack, Frederik Deweerdt, (Thu Apr 5, 6:53 am)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Thu Apr 5, 8:16 am)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Thu Apr 5, 10:02 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Thu Apr 5, 11:19 am)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Thu Apr 5, 1:31 pm)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Fri Apr 6, 6:23 am)
Re: 2.6.21-rc5-mm4, Eric W. Biederman, (Fri Apr 6, 7:32 am)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Fri Apr 6, 8:26 am)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Fri Apr 6, 12:33 pm)
Re: [PATCH] cache_k8_northbridges() overflows beyond alloc ..., Christoph Lameter, (Fri Apr 13, 11:07 am)