Re: 2.6.21-rc5-mm4 (SLUB)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Wednesday, April 4, 2007 - 9:29 pm

Here is a patch that adds validation (only for cpuslabs and partial 
slabs but thats where the action is). Apply this patch
and then do

echo 1 >/sys/slab/<cache-to-check>/validate

I suggest to boot with full debugging and then run this on the ACPI slabs.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.21-rc5-mm4/mm/slub.c
===================================================================
--- linux-2.6.21-rc5-mm4.orig/mm/slub.c	2007-04-04 20:26:03.000000000 -0700
+++ linux-2.6.21-rc5-mm4/mm/slub.c	2007-04-04 21:26:15.000000000 -0700
@@ -2280,6 +2280,67 @@ void *__kmalloc_node_track_caller(size_t
 
 #ifdef CONFIG_SYSFS
 
+static int validate_slab(struct kmem_cache *s, struct page *page)
+{
+	void *p;
+	void *addr = page_address(page);
+	unsigned long map[BITS_TO_LONGS(s->objects)];
+
+	if (!check_slab(s, page) ||
+			!on_freelist(s, page, NULL))
+		return 0;
+
+	/* Now we know that a valid freelist exists */
+	bitmap_zero(map, s->objects);
+
+	for(p = page->freelist; p; p = get_freepointer(s, p)) {
+		set_bit((p - addr) / s->size, map);
+		if (!check_object(s, page, p, 0))
+			return 0;
+	}
+
+	for(p = addr; p < addr + s->objects * s->size; p += s->size)
+		if (!test_bit((p - addr) / s->size, map))
+			if (!check_object(s, page, p, 1))
+				return 0;
+	return 1;
+}
+
+static int validate_slab_node(struct kmem_cache *s, struct kmem_cache_node *n)
+{
+	int count = 0;
+	struct page *page;
+	unsigned long flags;
+
+	spin_lock_irqsave(&n->list_lock, flags);
+	list_for_each_entry(page, &n->partial, lru) {
+		if (slab_trylock(page)) {
+			validate_slab(s, page);
+			slab_unlock(page);
+		} else
+			printk(KERN_INFO "Skipped busy slab %p\n", page);
+		count++;
+	}
+	spin_unlock_irqrestore(&n->list_lock, flags);
+	return count;
+}
+
+static void validate_slab_cache(struct kmem_cache *s)
+{
+	int node;
+	int count = 0;
+
+	printk(KERN_INFO "--- Validating slabcache '%s'\n", s->name);
+	flush_all(s);
+	for_each_online_node(node) {
+		struct kmem_cache_node *n = get_node(s, node);
+
+		count += validate_slab_node(s, n);
+	}
+	printk(KERN_INFO "--- Checked %d slabs in '%s'\n",
+		count, s->name);
+}
+
 static unsigned long count_partial(struct kmem_cache_node *n)
 {
 	unsigned long flags;
@@ -2402,7 +2463,6 @@ struct slab_attribute {
 	static struct slab_attribute _name##_attr =  \
 	__ATTR(_name, 0644, _name##_show, _name##_store)
 
-
 static ssize_t slab_size_show(struct kmem_cache *s, char *buf)
 {
 	return sprintf(buf, "%d\n", s->size);
@@ -2609,6 +2669,22 @@ static ssize_t store_user_store(struct k
 }
 SLAB_ATTR(store_user);
 
+static ssize_t validate_show(struct kmem_cache *s, char *buf)
+{
+	return 0;
+}
+
+static ssize_t validate_store(struct kmem_cache *s,
+			const char *buf, size_t length)
+{
+	if (buf[0] == '1')
+		validate_slab_cache(s);
+	else
+		return -EINVAL;
+	return length;
+}
+SLAB_ATTR(validate);
+
 #ifdef CONFIG_NUMA
 static ssize_t defrag_ratio_show(struct kmem_cache *s, char *buf)
 {
@@ -2648,6 +2724,7 @@ static struct attribute * slab_attrs[] =
 	&red_zone_attr.attr,
 	&poison_attr.attr,
 	&store_user_attr.attr,
+	&validate_attr.attr,
 #ifdef CONFIG_ZONE_DMA
 	&cache_dma_attr.attr,
 #endif
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.21-rc5-mm4, Andrew Morton, (Mon Apr 2, 10:47 pm)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Tue Apr 3, 5:57 am)
Re: 2.6.21-rc5-mm4, Kok, Auke, (Tue Apr 3, 8:11 am)
Re: 2.6.21-rc5-mm4, Michal Piotrowski, (Tue Apr 3, 9:11 am)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Tue Apr 3, 9:30 am)
Re: 2.6.21-rc5-mm4, Kok, Auke, (Tue Apr 3, 10:19 am)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Tue Apr 3, 10:42 am)
Re: 2.6.21-rc5-mm4, Randy Dunlap, (Tue Apr 3, 12:48 pm)
Re: 2.6.21-rc5-mm4, Davide Libenzi, (Tue Apr 3, 12:51 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 1:31 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 1:40 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 2:55 pm)
Re: 2.6.21-rc5-mm4, Michal Piotrowski, (Tue Apr 3, 3:20 pm)
Re: 2.6.21-rc5-mm4, Con Kolivas, (Tue Apr 3, 3:31 pm)
Re: 2.6.21-rc5-mm4, J.A. , (Tue Apr 3, 3:40 pm)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Tue Apr 3, 3:51 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 3:53 pm)
Re: 2.6.21-rc5-mm4, J.A. , (Tue Apr 3, 3:58 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 3:59 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:19 pm)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Tue Apr 3, 4:22 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:27 pm)
Re: 2.6.21-rc5-mm4, Michal Piotrowski, (Tue Apr 3, 4:31 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:38 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:40 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:40 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:41 pm)
Re: 2.6.21-rc5-mm4, J.A. , (Tue Apr 3, 4:43 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Tue Apr 3, 4:51 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 4:55 pm)
Re: 2.6.21-rc5-mm4, Christoph Lameter, (Tue Apr 3, 6:16 pm)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Tue Apr 3, 6:35 pm)
Re: 2.6.21-rc5-mm4, Randy Dunlap, (Tue Apr 3, 7:20 pm)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Tue Apr 3, 7:46 pm)
Re: 2.6.21-rc5-mm4, Randy Dunlap, (Tue Apr 3, 8:37 pm)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Wed Apr 4, 7:53 am)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Wed Apr 4, 8:12 am)
[-mm patch] net/: possible cleanups, Adrian Bunk, (Wed Apr 4, 8:25 am)
[-mm patch] unexport pci_proc_attach_device, Adrian Bunk, (Wed Apr 4, 8:25 am)
Re: 2.6.21-rc5-mm4, Badari Pulavarty, (Wed Apr 4, 8:27 am)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Wed Apr 4, 9:10 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 10:03 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Christoph Lameter, (Wed Apr 4, 10:13 am)
Re: 2.6.21-rc5-mm4, Eric W. Biederman, (Wed Apr 4, 10:22 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Badari Pulavarty, (Wed Apr 4, 10:33 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Christoph Lameter, (Wed Apr 4, 10:35 am)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Wed Apr 4, 10:55 am)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 11:02 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 11:04 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 11:09 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 11:22 am)
Re: 2.6.21-rc5-mm4 (SLUB powerpc), Badari Pulavarty, (Wed Apr 4, 1:53 pm)
Re: 2.6.21-rc5-mm4, Antonino A. Daplas, (Wed Apr 4, 2:56 pm)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Wed Apr 4, 3:10 pm)
Re: 2.6.21-rc5-mm4, Con Kolivas, (Wed Apr 4, 3:38 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 3:53 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 3:59 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 4:42 pm)
Re: 2.6.21-rc5-mm4, Antonino A. Daplas, (Wed Apr 4, 4:55 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 5:31 pm)
Re: 2.6.21-rc5-mm4, Antonino A. Daplas, (Wed Apr 4, 5:56 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Wed Apr 4, 7:44 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 8:15 pm)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Wed Apr 4, 9:29 pm)
Re: 2.6.21-rc5-mm4, Sam Ravnborg, (Thu Apr 5, 4:14 am)
[-mm patch] pcm_native: lockdep warning when launching jack, Frederik Deweerdt, (Thu Apr 5, 6:53 am)
Re: 2.6.21-rc5-mm4 (SLUB), Badari Pulavarty, (Thu Apr 5, 8:16 am)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Thu Apr 5, 10:02 am)
Re: 2.6.21-rc5-mm4 (SLUB), Christoph Lameter, (Thu Apr 5, 11:19 am)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Thu Apr 5, 1:31 pm)
Re: 2.6.21-rc5-mm4, Jiri Kosina, (Fri Apr 6, 6:23 am)
Re: 2.6.21-rc5-mm4, Eric W. Biederman, (Fri Apr 6, 7:32 am)
Re: 2.6.21-rc5-mm4, Valdis.Kletnieks, (Fri Apr 6, 8:26 am)
Re: 2.6.21-rc5-mm4, Andrew Morton, (Fri Apr 6, 12:33 pm)
Re: [PATCH] cache_k8_northbridges() overflows beyond alloc ..., Christoph Lameter, (Fri Apr 13, 11:07 am)