Re: [PATCH, take4] FUTEX : new PRIVATE futexes

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Eric Dumazet

Subject: Re: [PATCH, take4] FUTEX : new PRIVATE futexes

Date: Saturday, April 7, 2007 - 4:54 am

Jakub Jelinek a écrit :
quoted text> On Sat, Apr 07, 2007 at 10:43:39AM +0200, Eric Dumazet wrote:
>> get_futex_key() does a check against sizeof(u32) regardless of futex being 64bits or not.
>> So it is possible a 64bit futex spans two pages of memory...
> 
> That would be a user bug.  32-bit futexes have to be 32-bit aligned, 64-bit
> futexes have to be 64-bit aligned.

I am not sure what you want to say.

User doing sys_futex64(0x......FFC, FUTEX_WAKE_OP, ...) and crashing kernel or 
corrupting data is ok because its a user bug ?

User is allowed to do anything, kernel must check and protect innocents.
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA impr ..., Eric Dumazet, (Thu Mar 15, 12:10 pm)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Nick Piggin, (Thu Mar 15, 1:15 pm)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Peter Zijlstra, (Fri Mar 16, 1:05 am)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Eric Dumazet, (Fri Mar 16, 2:30 am)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Peter Zijlstra, (Fri Mar 16, 3:10 am)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Eric Dumazet, (Fri Mar 16, 3:30 am)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Peter Zijlstra, (Fri Mar 16, 3:36 am)

Re: [PATCH 0/3] FUTEX : new PRIVATE futexes, SMP and NUMA ..., Ulrich Drepper, (Wed Apr 4, 12:16 am)

[PATCH] FUTEX : new PRIVATE futexes, Eric Dumazet, (Thu Apr 5, 10:49 am)

Re: [PATCH] FUTEX : new PRIVATE futexes, Ulrich Drepper, (Thu Apr 5, 1:43 pm)

Re: [PATCH] FUTEX : new PRIVATE futexes, Nick Piggin, (Thu Apr 5, 6:19 pm)

Re: [PATCH] FUTEX : new PRIVATE futexes, Eric Dumazet, (Thu Apr 5, 10:53 pm)

Re: [PATCH] FUTEX : new PRIVATE futexes, Hugh Dickins, (Thu Apr 5, 11:05 pm)

Re: [PATCH] FUTEX : new PRIVATE futexes, Nick Piggin, (Fri Apr 6, 4:50 am)

Shared futexes (was [PATCH] FUTEX : new PRIVATE futexes), Peter Zijlstra, (Fri Apr 6, 5:26 am)

Re: [PATCH] FUTEX : new PRIVATE futexes, Peter Zijlstra, (Fri Apr 6, 5:31 am)

Re: Shared futexes (was [PATCH] FUTEX : new PRIVATE futexes), Hugh Dickins, (Fri Apr 6, 6:02 am)

Re: Shared futexes (was [PATCH] FUTEX : new PRIVATE futexes), Peter Zijlstra, (Fri Apr 6, 6:15 am)

Re: Shared futexes (was [PATCH] FUTEX : new PRIVATE futexes), Nick Piggin, (Fri Apr 6, 6:15 am)

Re: Shared futexes (was [PATCH] FUTEX : new PRIVATE futexes), Peter Zijlstra, (Fri Apr 6, 6:22 am)

Re: Shared futexes (was [PATCH] FUTEX : new PRIVATE futexes), Nick Piggin, (Fri Apr 6, 6:40 am)

Re: [PATCH] FUTEX : new PRIVATE futexes, Jan Engelhardt, (Fri Apr 6, 10:41 am)

[PATCH, take4] FUTEX : new PRIVATE futexes, Eric Dumazet, (Sat Apr 7, 1:43 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Nick Piggin, (Sat Apr 7, 2:30 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Eric Dumazet, (Sat Apr 7, 3:00 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Jakub Jelinek, (Sat Apr 7, 4:18 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Eric Dumazet, (Sat Apr 7, 4:54 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Ulrich Drepper, (Sat Apr 7, 9:40 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Andrew Morton, (Sat Apr 7, 3:15 pm)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Eric Dumazet, (Tue Apr 10, 2:21 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Nick Piggin, (Wed Apr 11, 12:22 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Eric Dumazet, (Wed Apr 11, 1:14 am)

[PATCH, take5] FUTEX : new PRIVATE futexes, Eric Dumazet, (Wed Apr 11, 2:19 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Nick Piggin, (Wed Apr 11, 2:23 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Pierre Peiffer, (Wed Apr 11, 2:30 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Eric Dumazet, (Wed Apr 11, 2:35 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Nick Piggin, (Wed Apr 11, 2:39 am)

Re: [PATCH, take4] FUTEX : new PRIVATE futexes, Nick Piggin, (Wed Apr 11, 2:40 am)

Re: [PATCH, take5] FUTEX :