Re: select(0, ..) is valid ?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Andi Kleen

Date: Friday, May 18, 2007 - 6:21 am

On Wednesday 16 May 2007 17:37, Anton Blanchard wrote:
quoted text> Hi Hugh,
>
> > It's interesting that compat_core_sys_select() shows this kmalloc(0)
> > failure but core_sys_select() does not.  That's because core_sys_select()
> > avoids kmalloc by using a buffer on the stack for small allocations (and
> > 0 sure is small).  Shouldn't compat_core_sys_select() do just the same?
> > Or is SLUB going to be so efficient that doing so is a waste of time?
>
> Nice catch, the original optimisation from Andi is:
>
> http://git.kernel.org/git-new/?p=linux/kernel/git/torvalds/linux-2.6.git;a=
>commit;h=70674f95c0a2ea694d5c39f4e514f538a09be36f
>
> And I think it makes sense for the compat code to do it too.

Yes agreed. I just forgot the copy'n'pasted code when doing the original
change.

-Andi
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

select(0, ..) is valid ?, Badari Pulavarty, (Tue May 15, 10:29 am)

Re: select(0, ..) is valid ?, Mark Glines, (Tue May 15, 10:34 am)

Re: select(0, ..) is valid ?, Jiri Slaby, (Tue May 15, 10:36 am)

Re: select(0, ..) is valid ?, H. Peter Anvin, (Tue May 15, 10:42 am)

Re: select(0, ..) is valid ?, Alan Cox, (Tue May 15, 10:43 am)

Re: select(0, ..) is valid ?, Andrew Morton, (Tue May 15, 10:44 am)

Re: select(0, ..) is valid ?, Badari Pulavarty, (Tue May 15, 10:57 am)

Re: select(0, ..) is valid ?, Christoph Lameter, (Tue May 15, 11:10 am)

Re: select(0, ..) is valid ?, Andrew Morton, (Tue May 15, 11:30 am)

Re: select(0, ..) is valid ?, Christoph Lameter, (Tue May 15, 11:36 am)

Re: select(0, ..) is valid ?, Hugh Dickins, (Tue May 15, 11:44 am)

Re: select(0, ..) is valid ?, Anton Blanchard, (Wed May 16, 8:37 am)

Re: select(0, ..) is valid ?, Badari Pulavarty, (Wed May 16, 5:59 pm)

Re: select(0, ..) is valid ?, Andi Kleen, (Fri May 18, 6:21 am)

Re: select(0, ..) is valid ?, Nish Aravamudan, (Mon May 21, 6:21 pm)

Re: select(0, ..) is valid ?, Steve Fox