[PATCH 3/3]x86_64: early_printk for early debug port support

Previous thread: [PATCH 2/3]i386: early init pgt for fix virtual addr in head.S by Yinghai Lu on Sunday, May 20, 2007 - 10:19 pm. (6 messages)

Next thread: 2.6.21.1 on Fedora Core 6 breaks LVM/vgscan by Jonathan Woithe on Sunday, May 20, 2007 - 10:41 pm. (1 message)
From: Yinghai Lu
Date: Sunday, May 20, 2007 - 10:19 pm

add early dbgp to early_printk.

kernel command line:
earlyprintk=dbgp
or
earlyprintk=dbgp1

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
From: Andrew Morton
Date: Tuesday, May 22, 2007 - 12:31 pm

On Sun, 20 May 2007 22:19:18 -0700

Please try to sort out your email client?  MIME attachments are a pain to
reply to and are a pain to merge.

Please include a diffstat in patches so it is easy for people to see which
files are being altered.

The patch adds lots of new trailing whitespace.  Please trim that off


err, perhaps we should move ehci.h somewhere more accessible? 


Please convert the above into lowercase-named static inline C functions. 

Please put a blank line between the end of the local definitions and the



Use "if (", rather that "if(".








in here.  But nothing references early_dbgp_console, and another wraning is


Why were all these ifdefs added?


<fiddles>

OK, I went through the exercise of removing all the unused-symbol warnings
which DBGP_DEBUG=0 produces and guess what?  None of the code which you've
added does anything!  It all has to be moved inside DBGP_DEBUG to avoid
unused-symbol warnings.  It's all a big no-op if DBGP_DEBUG=0.  I suspect
you did all your test and devel with DBGP_DEBUG=1, then turned DBGP_DEBUG
off and shipped the code without retesting?




-

From: Yinghai Lu
Date: Tuesday, May 22, 2007 - 12:43 pm

Thanks. will format and test again. also will use KMail to mail it out.

YH
-

From: Andi Kleen
Date: Wednesday, July 18, 2007 - 3:10 pm

Just checking some old patches. Was there ever an update for this one?
What were the testing results? 



-

From: Yinghai Lu
Date: Wednesday, July 18, 2007 - 3:32 pm

not yet.

will create one from my local tree tonight.

YH
-

From: Yinghai Lu
Date: Thursday, July 19, 2007 - 12:04 am

please check the attachment. the diff to current Linus'd git.

after remove pci quirks for usb handoff, it could get boot log till
ohci try to reset the port with debug device. --- reset will fail.

Maybe Greg could continue debug it.

YH
Previous thread: [PATCH 2/3]i386: early init pgt for fix virtual addr in head.S by Yinghai Lu on Sunday, May 20, 2007 - 10:19 pm. (6 messages)

Next thread: 2.6.21.1 on Fedora Core 6 breaks LVM/vgscan by Jonathan Woithe on Sunday, May 20, 2007 - 10:41 pm. (1 message)