On Sun, 20 May 2007 22:19:18 -0700
Please try to sort out your email client? MIME attachments are a pain to
reply to and are a pain to merge.
Please include a diffstat in patches so it is easy for people to see which
files are being altered.
The patch adds lots of new trailing whitespace. Please trim that off
err, perhaps we should move ehci.h somewhere more accessible?
Please convert the above into lowercase-named static inline C functions.
Please put a blank line between the end of the local definitions and the
Use "if (", rather that "if(".
in here. But nothing references early_dbgp_console, and another wraning is
Why were all these ifdefs added?
<fiddles>
OK, I went through the exercise of removing all the unused-symbol warnings
which DBGP_DEBUG=0 produces and guess what? None of the code which you've
added does anything! It all has to be moved inside DBGP_DEBUG to avoid
unused-symbol warnings. It's all a big no-op if DBGP_DEBUG=0. I suspect
you did all your test and devel with DBGP_DEBUG=1, then turned DBGP_DEBUG
off and shipped the code without retesting?
-