Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware before hibernation/suspend

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Michael-Luke Jones
Date: Monday, May 28, 2007 - 3:26 am

On 28 May 2007, at 10:06, Kay Sievers wrote:


Sorry, I know this maybe be unintentional, but comments like this  
make me somewhat angry.

If there is no decent documentation as to how to do it the right way  
(tm), how do you expect people to do it the right way (tm)?


What I wrote above is especially true when the in-kernel APIs  
themselves do things the wrong way (tm) themselves. Thus, even more  
thought is required to work around this imperfect behaviour in a sane  
manner. And without documentation, every single device driver author  
has to go through this thought process themselves. Unsurprisingly,  
they often get it wrong. But as there's no decent documentation to do  
it right, it's *not* their fault. I'd suggest it's more the fault of  
the core kernel devs who fail to fix up a questionable firmware  
loading interface, then fail to document how to work around its  
shortcomings.

Again, apologies if this sounds angry, I don't want to start an  
argument. But as someone just starting out here, this kind of thing  
can be very frustrating, as even with the best will in the world,  
achieving the right way (tm) is basically impossible if those in the  
know about what the right way (tm) is fail to share this information.

Michael-Luke Jones

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH -mm 0/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Sun May 27, 1:29 pm)
[RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Sun May 27, 1:30 pm)
[RFC][PATCH -mm 2/3] PM: Disable usermode helper before hi ..., Rafael J. Wysocki, (Sun May 27, 1:30 pm)
[RFC][PATCH -mm 3/3] PM: Disable _request_firmware before ..., Rafael J. Wysocki, (Sun May 27, 1:31 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Sun May 27, 1:45 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Sun May 27, 2:45 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Sun May 27, 2:55 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Sun May 27, 3:01 pm)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Mon May 28, 12:43 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Mon May 28, 12:44 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 1:48 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 3:26 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 3:41 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Mon May 28, 4:22 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Mon May 28, 4:28 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 4:38 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 5:07 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 5:26 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Michael-Luke Jones, (Mon May 28, 6:10 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Mon May 28, 10:26 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Mon May 28, 10:29 am)
Re: [RFC][PATCH -mm 3/3] PM: Disable _request_firmware bef ..., Rafael J. Wysocki, (Mon May 28, 10:43 am)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Tue May 29, 3:24 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 1:44 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 2:11 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 10:42 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Wed May 30, 10:44 pm)
Re: [RFC][PATCH -mm 1/3] PM: Hibernation and suspend notifiers, Rafael J. Wysocki, (Thu May 31, 1:02 pm)
Re: [RFC][PATCH -mm 1/2] PM: Introduce hibernation and sus ..., Rafael J. Wysocki, (Mon Jun 4, 12:56 am)